You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2025/08/27 12:52:08 UTC

[PR] GEODE-10459: upgrade testcontainers [geode]

raboof opened a new pull request, #7916:
URL: https://github.com/apache/geode/pull/7916

   The acceptance tests appear to fail because `docker-compose` does not exist. Likely the GHA machines have moved to the new `docker compose` convention. This attempts upgrading testcontainers, as testcontainers is what's starting docker compose, and newer versions indeed do it through the `docker` executable.
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   <!-- Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GEODE-10459: upgrade testcontainers from 1.17.6 to 1.21.3 [geode]

Posted by "harmoncoffee (via GitHub)" <gi...@apache.org>.
harmoncoffee commented on PR #7916:
URL: https://github.com/apache/geode/pull/7916#issuecomment-3228990313

   I see you got the acceptance tests working with this change thats great! 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GEODE-10459: upgrade testcontainers [geode]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #7916:
URL: https://github.com/apache/geode/pull/7916#issuecomment-3228311418

   hmm this is strange:
   
   ```
   SingleServerSNIAcceptanceTest > initializationError FAILED
       org.testcontainers.containers.ContainerLaunchException: Local Docker Compose not found. Is docker-compose on the PATH?
           at org.testcontainers.containers.LocalDockerCompose.invoke(LocalDockerCompose.java:61)
           at org.testcontainers.containers.ComposeDelegate.runWithCompose(ComposeDelegate.java:241)
           at org.testcontainers.containers.ComposeDelegate.createServices(ComposeDelegate.java:163)
           at org.testcontainers.containers.DockerComposeContainer.start(DockerComposeContainer.java:139)
           at org.apache.geode.rules.DockerComposeRule$1.evaluate(DockerComposeRule.java:102)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GEODE-10459: upgrade testcontainers from 1.17.6 to 1.21.3 [geode]

Posted by "JinwooHwang-SAS (via GitHub)" <gi...@apache.org>.
JinwooHwang-SAS merged PR #7916:
URL: https://github.com/apache/geode/pull/7916


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org