You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sfuhrm <gi...@git.apache.org> on 2018/06/13 17:36:04 UTC
[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...
GitHub user sfuhrm opened a pull request:
https://github.com/apache/commons-collections/pull/42
Fix for 5 CheckStyle 3.0.0 plugin warnings.
Fixed 5 CheckStyle warnings.
There are still 11 warnings left which are false positive (JavadocMethod Unable to get class information for @throws tag 'FunctorException'.).
See also: https://github.com/checkstyle/checkstyle/issues/5088
Maven Checkstyle Plugin 3.0.0 uses CheckStyle 6.18.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sfuhrm/commons-collections CheckStyleFixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-collections/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 2a9a1105428fc37a1dea4b50baac3c5fce796b49
Author: Stephan Fuhrmann <s...@...>
Date: 2018-06-13T17:30:01Z
Fixed 5 CheckStyle 3.0.0 plugin warnings.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/42
Hi @sfuhrm , thanks for your contribution.
I had a look running `mvn clean site` against master, and checkstyle report is empty. How did you get the warnings?
Note that the project's settings are defined in `src/conf/checkstyle.xml`, and at the pom.xml I believe it's using checkstyle 3.0.0 in master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/42
I was confused too. Maybe it was fixed recently, or it was run with the IDE or with some other setting.
Thanks for updating the issue so quickly. And feel free to submit other pull requests :-)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.
Posted by sfuhrm <gi...@git.apache.org>.
Github user sfuhrm commented on the issue:
https://github.com/apache/commons-collections/pull/42
Hi @kinow
well I'm a little bit confused, neither
```
mvn checkstyle:checkstyle
```
nor
```
mvn clean site
```
bring an error. I'm closing this.
Thank you!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...
Posted by sfuhrm <gi...@git.apache.org>.
Github user sfuhrm closed the pull request at:
https://github.com/apache/commons-collections/pull/42
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-collections/pull/42
[](https://coveralls.io/builds/17473023)
Coverage remained the same at 87.386% when pulling **2a9a1105428fc37a1dea4b50baac3c5fce796b49 on sfuhrm:CheckStyleFixes** into **8f9e66fbf060b219ca810e7b8d1153699e410237 on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org