[GitHub] [echarts] pissang commented on pull request #14372: refactor(theme): make themes installable, provide self-registered lib, pure object lib and installable lib.

[GitBox <gi...@apache.org>]

pissang commented on pull request #14372:
URL: https://github.com/apache/echarts/pull/14372#issuecomment-789715630


   I personally don't want `theme` in the source folder because the naming and design of most themes are very indeterminate. In fact, I think a better solution is to put most of them in a separate package like `echarts-theme`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org