You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Nathan Marz (JIRA)" <ji...@apache.org> on 2008/12/18 22:31:44 UTC
[jira] Created: (THRIFT-239) Generate @Override annotations for all
overrided methods
Generate @Override annotations for all overrided methods
--------------------------------------------------------
Key: THRIFT-239
URL: https://issues.apache.org/jira/browse/THRIFT-239
Project: Thrift
Issue Type: Improvement
Components: Compiler (Java)
Reporter: Nathan Marz
This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-239) Generate @Override annotations for
all overrided methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666309#action_12666309 ]
Bryan Duxbury commented on THRIFT-239:
--------------------------------------
For those of us not using an IDE, can you list which methods need the @Override annotation?
> Generate @Override annotations for all overrided methods
> --------------------------------------------------------
>
> Key: THRIFT-239
> URL: https://issues.apache.org/jira/browse/THRIFT-239
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Nathan Marz
> Priority: Minor
>
> This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-239) Generate @Override annotations for all
overrided methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-239:
---------------------------------
Attachment: thrift-239.patch
I'm going to commit this patch. I tested it out locally and it appears to work just fine.
> Generate @Override annotations for all overrided methods
> --------------------------------------------------------
>
> Key: THRIFT-239
> URL: https://issues.apache.org/jira/browse/THRIFT-239
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Nathan Marz
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-239.patch
>
>
> This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-239) Generate @Override annotations for all
overrided methods
Posted by "Nathan Marz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Marz updated THRIFT-239:
-------------------------------
Priority: Minor (was: Major)
> Generate @Override annotations for all overrided methods
> --------------------------------------------------------
>
> Key: THRIFT-239
> URL: https://issues.apache.org/jira/browse/THRIFT-239
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Nathan Marz
> Priority: Minor
>
> This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-239) Generate @Override annotations for
all overrided methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-239:
------------------------------------
Assignee: Bryan Duxbury
> Generate @Override annotations for all overrided methods
> --------------------------------------------------------
>
> Key: THRIFT-239
> URL: https://issues.apache.org/jira/browse/THRIFT-239
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Nathan Marz
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-239.patch
>
>
> This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-239) Generate @Override annotations for
all overrided methods
Posted by "Nathan Marz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666700#action_12666700 ]
Nathan Marz commented on THRIFT-239:
------------------------------------
I think the only ones are:
equals
clone
hashcode
toString
> Generate @Override annotations for all overrided methods
> --------------------------------------------------------
>
> Key: THRIFT-239
> URL: https://issues.apache.org/jira/browse/THRIFT-239
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Nathan Marz
> Priority: Minor
>
> This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-239) Generate @Override annotations for
all overrided methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-239.
----------------------------------
Resolution: Fixed
Committed.
> Generate @Override annotations for all overrided methods
> --------------------------------------------------------
>
> Key: THRIFT-239
> URL: https://issues.apache.org/jira/browse/THRIFT-239
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Nathan Marz
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-239.patch
>
>
> This makes the code more complete. It's useful when you have your IDE set to show errors whenever the annotation isn't present (like I do).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.