You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apr.apache.org by Ruediger Pluem <rp...@apache.org> on 2009/04/02 20:49:41 UTC

Re: svn commit: r761344 - /apr/apr/trunk/memory/unix/apr_pools.c


On 04/02/2009 06:58 PM, mturk@apache.org wrote:
> Author: mturk
> Date: Thu Apr  2 16:58:40 2009
> New Revision: 761344
> 
> URL: http://svn.apache.org/viewvc?rev=761344&view=rev
> Log:
> Both cleanup and pre_cleanup can share the same free list.
> Axe the free_pre_cleanups and use free_cleanups for both
> 
> Modified:
>     apr/apr/trunk/memory/unix/apr_pools.c
> 
> Modified: apr/apr/trunk/memory/unix/apr_pools.c
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/memory/unix/apr_pools.c?rev=761344&r1=761343&r2=761344&view=diff
> ==============================================================================
> --- apr/apr/trunk/memory/unix/apr_pools.c (original)
> +++ apr/apr/trunk/memory/unix/apr_pools.c Thu Apr  2 16:58:40 2009

> @@ -791,7 +786,6 @@
>  
>      block_list_destroy_all(pool->blocks);
>      run_cleanups(&pool->final_cleanups);
> -    free_cleanups(&pool->final_cleanups);
>      block_list_destroy(&pool->final_block);
>      free(pool);
>  }

Guess this one was removed by mistake as it would lead to a memory leak.

Regards

Rüdiger