Re: [PR] [multistage] add maxRowsInJoin, maxRowsInWindow, numGroups to query response [pinot]

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on PR #17784:
URL: https://github.com/apache/pinot/pull/17784#issuecomment-3983706980

   > I believe stage stats is not a stable API yet either meaning this can break across releases.
   
   I wouldn't say so. That API is stable and publicly documented (see each operator in https://docs.pinot.apache.org/users/user-guide-query/multi-stage-query/operator-types). There may be cases where the broker cannot reconstruct stageStats, and that is something we want to improve, but I don't recall any case where stats were renamed or removed. In fact, removing entries from the Java enum is explicitly forbidden.
   
   > i feel that the current approach supplements the existing fields in the query response (maxRowsInJoinReached, maxRowsInWindowReached) well without having to understand the complexity of stage stats.
   
   Historically, we added a new entry in the response for whatever requirement someone has. As a result, today we have dozens of entries that are not very well-defined and verbose in code (requiring getters and setters for each new property).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org