You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/07/29 12:33:31 UTC
[GitHub] [incubator-kyuubi] zhaomin1423 commented on a diff in pull request #3146: [KYUUBI #3138] [Subtask] DorisSQLEngine - Add jdbc engine to dist
zhaomin1423 commented on code in PR #3146:
URL: https://github.com/apache/incubator-kyuubi/pull/3146#discussion_r933196821
##########
build/dist:
##########
@@ -256,6 +257,9 @@ cp -r "$KYUUBI_HOME/externals/kyuubi-trino-engine/target/scala-$SCALA_VERSION/ja
# Copy hive engines
cp "$KYUUBI_HOME/externals/kyuubi-hive-sql-engine/target/kyuubi-hive-sql-engine_${SCALA_VERSION}-${VERSION}.jar" "$DISTDIR/externals/engines/hive"
+# Copy jdbc engines
+cp "$KYUUBI_HOME/externals/kyuubi-jdbc-engine/target/kyuubi-jdbc-engine_${SCALA_VERSION}-${VERSION}.jar" "$DISTDIR/externals/engines/jdbc"
Review Comment:
Yes, https://github.com/apache/incubator-kyuubi/pull/3125. I think that putting jars to the folder is ok, but I want to know your concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org