[GitHub] [hadoop] goiri commented on a diff in pull request #4292: HADOOP-18229. Fix Hadoop-Common JavaDoc Error

[GitBox <gi...@apache.org>]

goiri commented on code in PR #4292:
URL: https://github.com/apache/hadoop/pull/4292#discussion_r872617446


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:
##########
@@ -3582,7 +3591,9 @@ public void writeXml(Writer out) throws IOException {
    * the configuration, this method throws an {@link IllegalArgumentException}.
    * </li>
    * </ul>
+   * @param propertyName xml property name

Review Comment:
   Be consistent with the . at the end



##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:
##########
@@ -2785,15 +2791,16 @@ public void setClass(String name, Class<?> theClass, Class<?> xface) {
     set(name, theClass.getName());
   }
 
-  /** 
+  /**
    * Get a local file under a directory named by <i>dirsProp</i> with
    * the given <i>path</i>.  If <i>dirsProp</i> contains multiple directories,
    * then one is chosen based on <i>path</i>'s hash code.  If the selected
    * directory does not exist, an attempt is made to create it.
-   * 
+   *
    * @param dirsProp directory in which to locate the file.
-   * @param path file-path.
+   * @param path     file-path.

Review Comment:
   Why the extra spaces?



##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationException.java:
##########
@@ -59,6 +59,10 @@ public ReconfigurationException() {
 
   /**
    * Create a new instance of {@link ReconfigurationException}.
+   * @param property property name

Review Comment:
   . consistency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org