You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/07/08 00:14:38 UTC

Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36279/
-----------------------------------------------------------

(Updated July 7, 2015, 3:14 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.


Repository: mesos


Description
-------

Doxygen-ification of comments in libprocess IO headers.


Diffs
-----

  3rdparty/libprocess/include/process/io.hpp 63887704743f53c6e49ab504f549419e1d5910ce 

Diff: https://reviews.apache.org/r/36279/diff/


Testing
-------

`doxygen ../Doxyfile` and visually verified the HTML output.


Thanks,

Joseph Wu


Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36279/#review90823
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36279]

All tests passed.

- Mesos ReviewBot


On July 7, 2015, 10:14 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36279/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Doxygen-ification of comments in libprocess IO headers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp 63887704743f53c6e49ab504f549419e1d5910ce 
> 
> Diff: https://reviews.apache.org/r/36279/diff/
> 
> 
> Testing
> -------
> 
> `doxygen ../Doxyfile` and visually verified the HTML output.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36279/#review92545
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 7, 2015, 10:14 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36279/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Doxygen-ification of comments in libprocess IO headers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp 63887704743f53c6e49ab504f549419e1d5910ce 
> 
> Diff: https://reviews.apache.org/r/36279/diff/
> 
> 
> Testing
> -------
> 
> `doxygen ../Doxyfile` and visually verified the HTML output.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>