You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/29 22:53:11 UTC

[GitHub] [incubator-mxnet] connorgoggins opened a new pull request #17475: Implement remaining nn_activation ops in opperf

connorgoggins opened a new pull request #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475
 
 
   ## Description ##
   This PR serves to implement the remaining operators from the nn_activation category in opperf. To achieve this, I refactored the preexisting individual `run_performance_test` calls (for the four operators that had already been implemented) into a single generalized function call to `run_op_benchmarks`. I also implemented Softmax, SoftmaxActivation, softmin, and Activation ops, which are also called via the `run_op_benchmarks` function.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - M benchmark/opperf/nd_operations/nn_activation_operators.py
   - M benchmark/opperf/rules/default_params.py
   - M benchmark/opperf/utils/op_registry_utils.py
   
   ## Comments ##
   Tested on c5.18xl-ubuntu 16.04 and Mac OS with:
   1. Checkout branch and call function `run_activation_operators_benchmarks` - runs all activation ops on default data
   2. Checkout branch and run `opperf.py` (full run of all ops)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17475: Implement remaining nn_activation ops in opperf

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475#issuecomment-580971022
 
 
   @mxnet-label-bot add [pr-awaiting-review]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #17475: Implement remaining nn_activation ops in opperf

Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475#issuecomment-580542057
 
 
   [Group of operator test - all NN Activation ops (CPU)](https://gist.github.com/connorgoggins/038b868a9da1fb11ce42b8f061ae6a29)
   [Full OpPerf test (CPU)](https://gist.github.com/connorgoggins/fa0d486c37cf0f0f3f782e0411400eee)
   
   GPU results coming soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] apeforest merged pull request #17475: Implement remaining nn_activation ops in opperf

Posted by GitBox <gi...@apache.org>.
apeforest merged pull request #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17475: Implement remaining nn_activation ops in opperf

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475#issuecomment-580542057
 
 
   [Group of operator test - all NN Basic ops (CPU)](https://gist.github.com/connorgoggins/038b868a9da1fb11ce42b8f061ae6a29)
   [Full OpPerf test (CPU)](https://gist.github.com/connorgoggins/fa0d486c37cf0f0f3f782e0411400eee)
   
   GPU results coming soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17475: Implement remaining nn_activation ops in opperf

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475#issuecomment-581716815
 
 
   Incorrect way to rebase @connorgoggins 
   
   First get your master branch updated
   
   ```
   git remote add upstream https://github.com/apache/incubator-mxnet
   git checkout master
   git fetch upstream master
   git merge upstream/master
   git push origin master
   ```
   
   Once your fork master is sync'ed with remote master, rebase your branch on master
   ```
   git checkout <branchname>
   git rebase master
   git push origin <branchname>
   ```
   
   Let me know if this works!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17475: Implement remaining nn_activation ops in opperf

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17475: Implement remaining nn_activation ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17475#issuecomment-580549737
 
 
   [Group of operator test - all NN Activation ops (GPU)](https://gist.github.com/connorgoggins/951bd23e438bb4991b446151e6db8249)
   [Full OpPerf test (GPU)](https://gist.github.com/connorgoggins/c4d9849e419b5beaf2b0c2395966c067)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services