You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2026/03/26 22:25:16 UTC
[PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
yihua opened a new pull request, #18396:
URL: https://github.com/apache/hudi/pull/18396
### Describe the issue this Pull Request addresses
Custom merge handle implementation needs input data characteristics such as updates to determine different strategies. Such characteristics is known based on the workload profiling, but not visible to the merge handle.
### Summary and Changelog
This PR makes the changes so that the merge handle knows the number of updates from workload profiling:
- Propagates the number of update records per file from workload profiling (tagging) through `BucketInfo` → `UpsertPartitioner` → `handleUpdate` → `HoodieMergeHandleFactory` → merge handle constructors, so merge handles know the expected number of incoming updates at construction time.
- Introduces `MergeContext<T>` to wrap `numIncomingUpdates` and the record iterator into a single context object, replacing loose constructor parameters across the merge handle class hierarchy.
- Adds `numUpdates` field to `BucketInfo` (default `-1` for unknown/legacy callers) and `numIncomingUpdates` field to `HoodieAbstractMergeHandle` (via `MergeContext`), threaded through all subclasses (`HoodieWriteMergeHandle`, `FileGroupReaderBasedMergeHandle`, `HoodieSortedMergeHandle`, `HoodieMergeHandleWithChangeLog`, `HoodieSortedMergeHandleWithChangeLog`, `HoodieConcatHandle`). For now, only Spark side has the number of updates propagated.
- Uses `MergeContext.class` in the reflection-based `constructorParamTypes` in `HoodieMergeHandleFactory` to match the refactored constructor signatures.
### Impact
Merge handle implementation can use the number of updates for different strategies.
### Risk Level
none
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164788542
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.27%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 45.27% -23.26%
+ Complexity 27968 15445 -12523
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 50374 -41764
- Misses 35054 55495 +20441
+ Partials 7264 5398 -1866
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1551 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165266556
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.75%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 45.75% -22.78%
+ Complexity 27968 15234 -12734
=============================================
Files 2440 1968 -472
Lines 134456 108659 -25797
Branches 16226 13504 -2722
=============================================
- Hits 92138 49716 -42422
- Misses 35054 53707 +18653
+ Partials 7264 5236 -2028
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <71.79%> (-12.84%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138962645
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.42%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.42% -0.96%
+ Complexity 27573 27209 -364
============================================
Files 2433 2434 +1
Lines 133268 133282 +14
Branches 16034 16032 -2
============================================
- Hits 91122 89861 -1261
- Misses 35093 36288 +1195
- Partials 7053 7133 +80
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <76.92%> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <71.79%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [177 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164882438
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.07%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 66.07% -2.45%
+ Complexity 27968 26880 -1088
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 88856 -3282
- Misses 35054 38195 +3141
- Partials 7264 7419 +155
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [327 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165368430
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.64%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.64% -0.88%
+ Complexity 27968 27610 -358
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90965 -1173
- Misses 35054 36163 +1109
- Partials 7264 7342 +78
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <76.92%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [156 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165358027
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.40%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.40% -1.13%
+ Complexity 27968 27482 -486
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90640 -1498
- Misses 35054 36555 +1501
- Partials 7264 7275 +11
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <76.92%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <71.79%> (-0.36%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [187 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5292294469
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* cba938e5d68f36a45e574a189ff748c65e159cbd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165269097
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.75%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 45.75% -22.78%
+ Complexity 27968 15234 -12734
=============================================
Files 2440 1968 -472
Lines 134456 108659 -25797
Branches 16226 13504 -2722
=============================================
- Hits 92138 49716 -42422
- Misses 35054 53707 +18653
+ Partials 7264 5236 -2028
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <71.79%> (-12.84%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165239646
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.94%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 53.94% -14.59%
+ Complexity 27968 12201 -15767
=============================================
Files 2440 1424 -1016
Lines 134456 70558 -63898
Branches 16226 7925 -8301
=============================================
- Hits 92138 38062 -54076
+ Misses 35054 29092 -5962
+ Partials 7264 3404 -3860
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `55.84% <100.00%> (-35.07%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `38.98% <ø> (-32.21%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1780 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164825075
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.53%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 54.53% -14.00%
+ Complexity 27968 18334 -9634
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 60674 -31464
- Misses 35054 44380 +9326
+ Partials 7264 6213 -1051
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.38% <100.00%> (-10.68%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1367 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165762861
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 569d6b50ee183036b43bcb939ff8c938b6fbc1e1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138906581
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.36%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 45.36% -23.01%
+ Complexity 27573 15403 -12170
=============================================
Files 2433 1995 -438
Lines 133268 110596 -22672
Branches 16034 13904 -2130
=============================================
- Hits 91122 50176 -40946
- Misses 35093 55087 +19994
+ Partials 7053 5333 -1720
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <71.79%> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1541 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138972258
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.53%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.53% -0.85%
+ Complexity 27573 27253 -320
============================================
Files 2433 2434 +1
Lines 133268 133282 +14
Branches 16034 16032 -2
============================================
- Hits 91122 90008 -1114
- Misses 35093 36155 +1062
- Partials 7053 7119 +66
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <76.92%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [142 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3036286741
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/BaseFlinkCommitActionExecutor.java:
##########
@@ -167,13 +167,13 @@ protected Iterator<List<WriteStatus>> handleUpsertPartition(
// and append instead of UPDATE.
return handleInsert(fileIdHint, recordItr);
} else if (this.writeHandle instanceof HoodieWriteMergeHandle) {
- return handleUpdate(partitionPath, fileIdHint, recordItr);
+ return handleUpdate(partitionPath, fileIdHint, -1L, recordItr);
Review Comment:
🤖 nit: `-1L` is a magic sentinel here (meaning "unknown update count"). Could you extract a named constant like `UNKNOWN_NUM_UPDATES = -1L` and use it in both call sites? Makes the intent a lot clearer when reading the call.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/MergeContext.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io;
+
+import org.apache.hudi.common.model.HoodieRecord;
+
+import java.util.Iterator;
+
+/**
+ * Context for merge handle creation, carrying incoming data and characteristics
+ */
+public class MergeContext<T> {
+
+ /**
+ * The estimated number of incoming update and delete records to merge
+ * A value of -1 means unknown.
+ */
+ private final long numIncomingUpdates;
+
+ /**
+ * Iterator over the incoming records to be merged.
+ */
+ private final Iterator<HoodieRecord<T>> recordItr;
+
+ private MergeContext(long numIncomingUpdates, Iterator<HoodieRecord<T>> recordItr) {
+ this.numIncomingUpdates = numIncomingUpdates;
+ this.recordItr = recordItr;
+ }
+
+ public static <T> MergeContext<T> create(long numIncomingUpdates, Iterator<HoodieRecord<T>> recordItr) {
+ return new MergeContext<>(numIncomingUpdates, recordItr);
+ }
+
+ public static <T> MergeContext<T> create(Iterator<HoodieRecord<T>> recordItr) {
+ return new MergeContext<>(-1L, recordItr);
+ }
+
Review Comment:
🤖 nit: the `-1L` sentinel for "unknown" is repeated here and in `BucketInfo` (and both Javadoc blocks). Could you extract it as a named constant like `public static final long UNKNOWN_NUM_UPDATES = -1L;` on `MergeContext` so all callers can reference `MergeContext.UNKNOWN_NUM_UPDATES` rather than scattering the magic value?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/MergeContext.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io;
+
+import org.apache.hudi.common.model.HoodieRecord;
+
+import java.util.Iterator;
+
+/**
+ * Context for merge handle creation, carrying incoming data and characteristics
+ */
+public class MergeContext<T> {
+
+ /**
+ * The estimated number of incoming update and delete records to merge
+ * A value of -1 means unknown.
+ */
+ private final long numIncomingUpdates;
+
+ /**
+ * Iterator over the incoming records to be merged.
+ */
+ private final Iterator<HoodieRecord<T>> recordItr;
+
+ private MergeContext(long numIncomingUpdates, Iterator<HoodieRecord<T>> recordItr) {
+ this.numIncomingUpdates = numIncomingUpdates;
+ this.recordItr = recordItr;
+ }
+
+ public static <T> MergeContext<T> create(long numIncomingUpdates, Iterator<HoodieRecord<T>> recordItr) {
+ return new MergeContext<>(numIncomingUpdates, recordItr);
+ }
+
+ public static <T> MergeContext<T> create(Iterator<HoodieRecord<T>> recordItr) {
+ return new MergeContext<>(-1L, recordItr);
+ }
+
+ public long getNumIncomingUpdates() {
+ return numIncomingUpdates;
+ }
+
+ public Iterator<HoodieRecord<T>> getRecordItr() {
+ return recordItr;
+ }
Review Comment:
🤖 nit: `getRecordItr()` uses the abbreviated form — could you spell it out as `getRecordIterator()` for a bit more clarity at call sites?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAbstractMergeHandle.java:
##########
@@ -64,16 +67,18 @@ public abstract class HoodieAbstractMergeHandle<T, I, K, O> extends HoodieWriteH
* @param config Hoodie writer configs.
* @param instantTime current instant time.
* @param hoodieTable an instance of {@link HoodieTable}
+ * @param mergeContext context carrying incoming data to merge and characteristics
Review Comment:
🤖 nit: the `@param mergeContext` Javadoc is missing a trailing period — same pattern appears across several constructors in the PR. Could you add one for consistency with the surrounding Javadoc style?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -137,7 +137,7 @@ public HoodieWriteMergeHandle(HoodieWriteConfig config, String instantTime, Hood
Map<String, HoodieRecord<T>> keyToNewRecords, String partitionPath, String fileId,
HoodieBaseFile dataFileToBeMerged, TaskContextSupplier taskContextSupplier,
Option<BaseKeyGenerator> keyGeneratorOpt) {
- super(config, instantTime, hoodieTable, partitionPath, fileId, taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt,
+ super(config, instantTime, hoodieTable, MergeContext.create(Collections.emptyIterator()), partitionPath, fileId, taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt,
Review Comment:
🤖 nit: `MergeContext.create(Collections.emptyIterator())` here feels a bit misleading — this constructor receives records via `keyToNewRecords` directly and never uses the iterator from the context. A brief comment clarifying why the empty context is passed (or an overload that doesn't require one) might save the next reader a double-take.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAbstractMergeHandle.java:
##########
@@ -46,6 +46,9 @@
@Slf4j
public abstract class HoodieAbstractMergeHandle<T, I, K, O> extends HoodieWriteHandle<T, I, K, O> implements HoodieMergeHandle<T, I, K, O> {
+ // The number of incoming update records based on tagging; -1 means unknown
+ @Getter
+ protected long numIncomingUpdates = -1L;
Review Comment:
🤖 nit: could you extract `-1L` into a named constant (e.g. `UNKNOWN_NUM_INCOMING_UPDATES`)? The comment explains the sentinel well, but a constant makes it self-documenting at every use site too.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestUpdateSchemaEvolution.java:
##########
@@ -122,7 +124,7 @@ private void assertSchemaEvolutionOnUpdateResult(WriteStatus insertResult, Hoodi
jsc.parallelize(Arrays.asList(1)).map(x -> {
Executable executable = () -> {
HoodieWriteMergeHandle mergeHandle = new HoodieWriteMergeHandle(updateTable.getConfig(), "101", updateTable,
- updateRecords.iterator(), updateRecords.get(0).getPartitionPath(), insertResult.getFileId(), supplier, Option.empty());
+ MergeContext.create(updateRecords.size(), (Iterator) updateRecords.iterator()), updateRecords.get(0).getPartitionPath(), insertResult.getFileId(), supplier, Option.empty());
Review Comment:
🤖 nit: the raw `(Iterator)` cast here (and in a few spots in `TestMergeHandle.java`) is a little awkward — would it be possible to type the list as `List<HoodieRecord<T>>` upstream so the cast can be avoided, or at least use `@SuppressWarnings("unchecked")` alongside a typed cast like `(Iterator<HoodieRecord<T>>)`?
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/commit/JavaUpsertPartitioner.java:
##########
@@ -191,7 +191,7 @@ private void assignInserts(WorkloadProfile profile, HoodieEngineContext context)
} else {
recordsPerBucket.add(totalUnassignedInserts - (insertBuckets - 1) * insertRecordsPerBucket);
}
- BucketInfo bucketInfo = new BucketInfo(BucketType.INSERT, FSUtils.createNewFileIdPfx(), partitionPath);
+ BucketInfo bucketInfo = new BucketInfo(BucketType.INSERT, FSUtils.createNewFileIdPfx(), partitionPath, 0L);
Review Comment:
🤖 nit: the `0L` passed as `numUpdates` for an INSERT bucket reads a bit like a magic number — would a named constant (e.g. `NO_UPDATES = 0L`) or even just a comment clarify that inserts carry no update count?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java:
##########
@@ -392,30 +404,47 @@ private HoodieWriteConfig.Builder makeHoodieClientConfigBuilder() {
@Test
void testMapAndListBasedSparkBucketInfoGetter() {
- List<BucketInfo> bucketInfos = Arrays.asList(new BucketInfo(BucketType.UPDATE, "bucket1", "partition1"),
- new BucketInfo(BucketType.UPDATE, "bucket2", "partition2"));
+ List<BucketInfo> bucketInfos = Arrays.asList(new BucketInfo(BucketType.UPDATE, "bucket1", "partition1", 42),
+ new BucketInfo(BucketType.UPDATE, "bucket2", "partition2", 99));
Map<Integer, BucketInfo> bucketInfoMap = new HashMap<>();
bucketInfoMap.put(0, bucketInfos.get(0));
bucketInfoMap.put(1, bucketInfos.get(1));
MapBasedSparkBucketInfoGetter getter = new MapBasedSparkBucketInfoGetter(bucketInfoMap);
ListBasedSparkBucketInfoGetter listGetter = new ListBasedSparkBucketInfoGetter(bucketInfos);
assertEquals(bucketInfos.get(0), getter.getBucketInfo(0));
assertEquals(bucketInfos.get(0), listGetter.getBucketInfo(0));
+ assertEquals(42, getter.getBucketInfo(0).getNumUpdates());
+ assertEquals(42, listGetter.getBucketInfo(0).getNumUpdates());
assertEquals(bucketInfos.get(1), getter.getBucketInfo(1));
assertEquals(bucketInfos.get(1), listGetter.getBucketInfo(1));
+ assertEquals(99, getter.getBucketInfo(1).getNumUpdates());
+ assertEquals(99, listGetter.getBucketInfo(1).getNumUpdates());
Review Comment:
🤖 nit: the `-1L` sentinel is hardcoded here (and again a few lines below in `testInsertOverwriteBucketInfoGetter`). If `BucketInfo` exposes a named constant for "unknown" (e.g., `UNKNOWN_NUM_UPDATES`), could the test reference that instead so the magic value doesn't have to be re-explained in every assertion message?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieConcatHandle.java:
##########
@@ -72,10 +72,10 @@ public class HoodieConcatHandle<T, I, K, O> extends HoodieWriteMergeHandle<T, I,
private final Iterator<HoodieRecord<T>> recordItr;
public HoodieConcatHandle(HoodieWriteConfig config, String instantTime, HoodieTable<T, I, K, O> hoodieTable,
- Iterator<HoodieRecord<T>> recordItr, String partitionPath, String fileId,
+ MergeContext<T> mergeContext, String partitionPath, String fileId,
TaskContextSupplier taskContextSupplier, Option<BaseKeyGenerator> keyGeneratorOpt) {
- super(config, instantTime, hoodieTable, Collections.emptyIterator(), partitionPath, fileId, taskContextSupplier, keyGeneratorOpt);
- this.recordItr = recordItr;
+ super(config, instantTime, hoodieTable, MergeContext.create(mergeContext.getNumIncomingUpdates(), Collections.emptyIterator()), partitionPath, fileId, taskContextSupplier, keyGeneratorOpt);
Review Comment:
🤖 nit: the inline `MergeContext.create(...)` nested inside `super(...)` makes this already-long line quite hard to parse. Since Java prevents pre-`super` statements, it might be worth considering an overload that accepts the count and iterator directly to avoid the double wrapping here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138901744
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.44%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 46.44% -21.93%
+ Complexity 27573 15051 -12522
=============================================
Files 2433 1949 -484
Lines 133268 105738 -27530
Branches 16034 12871 -3163
=============================================
- Hits 91122 49111 -42011
- Misses 35093 51583 +16490
+ Partials 7053 5044 -2009
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <71.79%> (-12.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164630152
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.66667%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.98%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 44.98% -23.55%
+ Complexity 27968 8463 -19505
=============================================
Files 2440 1195 -1245
Lines 134456 61663 -72793
Branches 16226 6612 -9614
=============================================
- Hits 92138 27739 -64399
+ Misses 35054 30906 -4148
+ Partials 7264 3018 -4246
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <100.00%> (-41.56%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `35.59% <ø> (-35.60%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `50.48% <100.00%> (-30.59%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `49.29% <ø> (-38.74%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `25.00% <100.00%> (-25.00%)` | :arrow_down: |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2036 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164777196
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.75%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 45.75% -22.78%
+ Complexity 27968 15233 -12735
=============================================
Files 2440 1968 -472
Lines 134456 108659 -25797
Branches 16226 13504 -2722
=============================================
- Hits 92138 49713 -42425
- Misses 35054 53710 +18656
+ Partials 7264 5236 -2028
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <71.79%> (-12.84%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164897407
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.57%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.57% -0.96%
+ Complexity 27968 27553 -415
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90864 -1274
- Misses 35054 36315 +1261
- Partials 7264 7291 +27
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <76.92%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164468743
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 290517350672bd44bac4f24fe00e81f268d1b3ef UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164792741
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.06%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.06% -20.47%
+ Complexity 27968 16346 -11622
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53481 -38657
- Misses 35054 52172 +17118
+ Partials 7264 5614 -1650
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.70% <71.79%> (-15.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1503 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4139031945
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.36%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 68.36% -0.02%
- Complexity 27573 27584 +11
============================================
Files 2433 2434 +1
Lines 133268 133296 +28
Branches 16034 16034
============================================
+ Hits 91122 91124 +2
- Misses 35093 35113 +20
- Partials 7053 7059 +6
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <82.05%> (-0.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.06% <100.00%> (ø)` | |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5208298715
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 569d6b50ee183036b43bcb939ff8c938b6fbc1e1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975)
* 150896db46eda5fdfc61b2ff6229e8a96fa62df6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4139035729
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.36%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 68.36% -0.02%
- Complexity 27573 27584 +11
============================================
Files 2433 2434 +1
Lines 133268 133296 +28
Branches 16034 16034
============================================
+ Hits 91122 91124 +2
- Misses 35093 35113 +20
- Partials 7053 7059 +6
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <82.05%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.06% <100.00%> (ø)` | |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4139033048
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.36%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 68.36% -0.02%
- Complexity 27573 27584 +11
============================================
Files 2433 2434 +1
Lines 133268 133296 +28
Branches 16034 16034
============================================
+ Hits 91122 91124 +2
- Misses 35093 35113 +20
- Partials 7053 7059 +6
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <82.05%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.06% <100.00%> (ø)` | |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164822543
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.50%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 54.50% -14.03%
+ Complexity 27968 18324 -9644
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 60641 -31497
- Misses 35054 44409 +9355
+ Partials 7264 6217 -1047
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <71.79%> (-15.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.38% <100.00%> (-10.68%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1367 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165291171
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.15%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.15% -20.37%
+ Complexity 27968 16376 -11592
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53586 -38552
- Misses 35054 52081 +17027
+ Partials 7264 5600 -1664
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <71.79%> (-15.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164881102
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.07%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 66.07% -2.45%
+ Complexity 27968 26880 -1088
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 88856 -3282
- Misses 35054 38195 +3141
- Partials 7264 7419 +155
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [327 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164934726
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.52%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.52%
- Complexity 27968 27969 +1
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92151 +13
Misses 35054 35054
- Partials 7264 7265 +1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <82.05%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138918278
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.22%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 48.22% -20.15%
+ Complexity 27573 16319 -11254
=============================================
Files 2433 1995 -438
Lines 133268 110610 -22658
Branches 16034 13906 -2128
=============================================
- Hits 91122 53346 -37776
- Misses 35093 51728 +16635
+ Partials 7053 5536 -1517
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.43% <71.79%> (-15.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <71.79%> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1493 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138930451
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.38%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 61.38% -6.99%
+ Complexity 27573 24741 -2832
============================================
Files 2433 2434 +1
Lines 133268 133268
Branches 16034 16030 -4
============================================
- Hits 91122 81810 -9312
- Misses 35093 44597 +9504
+ Partials 7053 6861 -192
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <71.79%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <71.79%> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.38% <100.00%> (-10.68%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [526 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5208837619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 150896db46eda5fdfc61b2ff6229e8a96fa62df6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165387234
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.52%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.52%
- Complexity 27968 27969 +1
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92151 +13
+ Misses 35054 35051 -3
- Partials 7264 7268 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <82.05%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164569563
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 290517350672bd44bac4f24fe00e81f268d1b3ef Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971)
* 66c0950dc3e42f9438bb21d4952039389e97d4dc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165321955
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 61.23% -7.30%
+ Complexity 27968 24886 -3082
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 82341 -9797
- Misses 35054 45229 +10175
+ Partials 7264 6900 -364
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [527 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165367326
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.64%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.64% -0.88%
+ Complexity 27968 27610 -358
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90965 -1173
- Misses 35054 36163 +1109
- Partials 7264 7342 +78
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <76.92%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [156 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138978198
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.35%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 68.35% -0.02%
- Complexity 27573 27581 +8
============================================
Files 2433 2434 +1
Lines 133268 133296 +28
Branches 16034 16034
============================================
- Hits 91122 91117 -5
- Misses 35093 35116 +23
- Partials 7053 7063 +10
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <82.05%> (-0.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.06% <100.00%> (ø)` | |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138987618
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.35%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 68.35% -0.02%
- Complexity 27573 27582 +9
============================================
Files 2433 2434 +1
Lines 133268 133296 +28
Branches 16034 16034
============================================
- Hits 91122 91119 -3
- Misses 35093 35115 +22
- Partials 7053 7062 +9
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.62% <82.05%> (-0.12%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.06% <100.00%> (ø)` | |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3036289387
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -67,13 +66,13 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
log.info("Create HoodieMergeHandle implementation {} {}", mergeHandleClasses.getLeft(), logContext);
Class<?>[] constructorParamTypes = new Class<?>[] {
- HoodieWriteConfig.class, String.class, HoodieTable.class, Iterator.class,
+ HoodieWriteConfig.class, String.class, HoodieTable.class, MergeContext.class,
Review Comment:
🤖 Changing the reflection-based constructor parameter types from `Iterator.class` to `MergeContext.class` is a breaking change for any custom merge handle implementation registered via config. Since `HoodieMergeHandle` is `@PublicAPIClass(EVOLVING)`, this is permissible, but it might be worth calling this out in the PR description or release notes so users with custom merge handles know to update their constructors.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -137,7 +137,7 @@ public HoodieWriteMergeHandle(HoodieWriteConfig config, String instantTime, Hood
Map<String, HoodieRecord<T>> keyToNewRecords, String partitionPath, String fileId,
HoodieBaseFile dataFileToBeMerged, TaskContextSupplier taskContextSupplier,
Option<BaseKeyGenerator> keyGeneratorOpt) {
- super(config, instantTime, hoodieTable, partitionPath, fileId, taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt,
+ super(config, instantTime, hoodieTable, MergeContext.create(Collections.emptyIterator()), partitionPath, fileId, taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt,
Review Comment:
🤖 The compaction constructor creates `MergeContext.create(Collections.emptyIterator())` without specifying `numIncomingUpdates`. Could you confirm that this factory method defaults `numIncomingUpdates` to `-1` (unknown)? If it defaults to `0`, downstream merge handle logic could incorrectly interpret this as "zero updates expected" rather than "unknown".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4540846433
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.53%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 187 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.53%
- Complexity 27968 27970 +2
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92159 +21
+ Misses 35054 35047 -7
Partials 7264 7264
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <82.05%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138931319
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.38%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 61.38% -6.99%
+ Complexity 27573 24741 -2832
============================================
Files 2433 2434 +1
Lines 133268 133268
Branches 16034 16030 -4
============================================
- Hits 91122 81810 -9312
- Misses 35093 44597 +9504
+ Partials 7053 6861 -192
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <71.79%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <71.79%> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.38% <100.00%> (-10.68%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [526 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138943802
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.94%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 65.94% -2.44%
+ Complexity 27573 26556 -1017
============================================
Files 2433 2434 +1
Lines 133268 133268
Branches 16034 16030 -4
============================================
- Hits 91122 87879 -3243
- Misses 35093 38120 +3027
- Partials 7053 7269 +216
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <71.79%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <71.79%> (-0.28%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.38% <100.00%> (-10.68%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [358 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138966273
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.49%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.49% -0.88%
+ Complexity 27573 27237 -336
============================================
Files 2433 2434 +1
Lines 133268 133282 +14
Branches 16034 16032 -2
============================================
- Hits 91122 89963 -1159
- Misses 35093 36201 +1108
- Partials 7053 7118 +65
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <76.92%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <71.79%> (-0.06%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [150 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138971260
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.53%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.53% -0.85%
+ Complexity 27573 27253 -320
============================================
Files 2433 2434 +1
Lines 133268 133282 +14
Branches 16034 16032 -2
============================================
- Hits 91122 90007 -1115
- Misses 35093 36156 +1063
- Partials 7053 7119 +66
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <76.92%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165352943
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.40%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.40% -1.13%
+ Complexity 27968 27482 -486
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90640 -1498
- Misses 35054 36555 +1501
- Partials 7264 7275 +11
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <76.92%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <71.79%> (-0.36%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [187 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4538312632
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.53%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 182 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.53%
- Complexity 27968 27970 +2
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92159 +21
+ Misses 35054 35047 -7
Partials 7264 7264
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <82.05%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165371993
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.66%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.66% -0.86%
+ Complexity 27968 27616 -352
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90995 -1143
- Misses 35054 36138 +1084
- Partials 7264 7337 +73
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <76.92%> (-3.77%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [149 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3795447840
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAbstractMergeHandle.java:
##########
@@ -46,6 +46,12 @@
@Slf4j
public abstract class HoodieAbstractMergeHandle<T, I, K, O> extends HoodieWriteHandle<T, I, K, O> implements HoodieMergeHandle<T, I, K, O> {
+ // The number of incoming update and delete records based on tagging; see the
+ // MergeContext#numUpdates javadoc for the exact semantics (lower bound, not iterator size).
Review Comment:
🤖 nit: `MergeContext#numUpdates` points to a private field — could you change it to `MergeContext#getNumUpdates()` so the reference resolves to the public accessor and its Javadoc in IDEs?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138974018
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.55%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.55% -0.83%
+ Complexity 27573 27268 -305
============================================
Files 2433 2434 +1
Lines 133268 133296 +28
Branches 16034 16034
============================================
- Hits 91122 90048 -1074
- Misses 35093 36129 +1036
- Partials 7053 7119 +66
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <76.92%> (-3.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [134 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138900531
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.94%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 46.94% -21.43%
+ Complexity 27573 14887 -12686
=============================================
Files 2433 1932 -501
Lines 133268 103390 -29878
Branches 16034 12291 -3743
=============================================
- Hits 91122 48538 -42584
- Misses 35093 49918 +14825
+ Partials 7053 4934 -2119
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.36% <71.79%> (-12.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1586 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164807006
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.10%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.10% -20.43%
+ Complexity 27968 16360 -11608
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53521 -38617
- Misses 35054 52137 +17083
+ Partials 7264 5609 -1655
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.28% <71.79%> (-15.50%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1502 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164923813
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.42%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 68.42% -0.10%
+ Complexity 27968 27907 -61
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 92017 -121
- Misses 35054 35232 +178
+ Partials 7264 7221 -43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <82.05%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165375187
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.69%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.69% -0.84%
+ Complexity 27968 27623 -345
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 91024 -1114
- Misses 35054 36110 +1056
- Partials 7264 7336 +72
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <76.92%> (-3.73%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [142 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164819986
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.49%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 54.49% -14.03%
+ Complexity 27968 18323 -9645
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 60640 -31498
- Misses 35054 44409 +9355
+ Partials 7264 6218 -1046
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <71.79%> (-15.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.38% <100.00%> (-10.68%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1367 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164894018
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.50%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.50% -1.02%
+ Complexity 27968 27518 -450
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90779 -1359
- Misses 35054 36387 +1333
- Partials 7264 7304 +40
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.49% <76.92%> (-6.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [171 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164880413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 290517350672bd44bac4f24fe00e81f268d1b3ef Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971)
* 66c0950dc3e42f9438bb21d4952039389e97d4dc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165025569
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 290517350672bd44bac4f24fe00e81f268d1b3ef Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971)
* 66c0950dc3e42f9438bb21d4952039389e97d4dc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973)
* 569d6b50ee183036b43bcb939ff8c938b6fbc1e1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165349209
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.93%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 65.93% -2.59%
+ Complexity 27968 26815 -1153
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 88666 -3472
- Misses 35054 38405 +3351
- Partials 7264 7399 +135
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <71.79%> (-0.36%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [348 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165263439
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.91%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 46.91% -21.61%
+ Complexity 27968 14912 -13056
=============================================
Files 2440 1934 -506
Lines 134456 103971 -30485
Branches 16226 12506 -3720
=============================================
- Hits 92138 48783 -43355
- Misses 35054 50239 +15185
+ Partials 7264 4949 -2315
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.37% <71.79%> (-12.27%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1586 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165263574
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 290517350672bd44bac4f24fe00e81f268d1b3ef Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971)
* 66c0950dc3e42f9438bb21d4952039389e97d4dc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973)
* 569d6b50ee183036b43bcb939ff8c938b6fbc1e1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5314554097
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
}, {
"hash" : "a776077238124c31dbdab4a08a51af68a83dec84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309",
"triggerID" : "a776077238124c31dbdab4a08a51af68a83dec84",
"triggerType" : "PUSH"
}, {
"hash" : "e73a493d9b408824893afd88099463644795d410",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e73a493d9b408824893afd88099463644795d410",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* a776077238124c31dbdab4a08a51af68a83dec84 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309)
* e73a493d9b408824893afd88099463644795d410 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #18396:
URL: https://github.com/apache/hudi/pull/18396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164994853
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.53%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.53%
- Complexity 27968 27969 +1
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92154 +16
+ Misses 35054 35052 -2
Partials 7264 7264
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.74% <82.05%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164523247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 290517350672bd44bac4f24fe00e81f268d1b3ef Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165318684
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 61.23% -7.30%
+ Complexity 27968 24885 -3083
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 82340 -9798
- Misses 35054 45229 +10175
+ Partials 7264 6901 -363
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [527 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165323911
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 61.23% -7.30%
+ Complexity 27968 24886 -3082
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 82341 -9797
- Misses 35054 45229 +10175
+ Partials 7264 6900 -364
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [527 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3035648231
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -67,13 +66,13 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
log.info("Create HoodieMergeHandle implementation {} {}", mergeHandleClasses.getLeft(), logContext);
Class<?>[] constructorParamTypes = new Class<?>[] {
- HoodieWriteConfig.class, String.class, HoodieTable.class, Iterator.class,
+ HoodieWriteConfig.class, String.class, HoodieTable.class, MergeContext.class,
Review Comment:
🤖 The constructor lookup now requires `MergeContext.class` instead of `Iterator.class`. This is a breaking change for any custom merge handle implementations registered via config — their constructors won't be found by reflection. Would it be worth adding a fallback that tries the old `Iterator.class` signature, or at least documenting the migration in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138927461
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.29%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 48.29% -20.09%
+ Complexity 27573 16342 -11231
=============================================
Files 2433 1995 -438
Lines 133268 110610 -22658
Branches 16034 13906 -2128
=============================================
- Hits 91122 53419 -37703
- Misses 35093 51664 +16571
+ Partials 7053 5527 -1526
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <71.79%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <71.79%> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1492 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138922028
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.26%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 48.26% -20.12%
+ Complexity 27573 16332 -11241
=============================================
Files 2433 1995 -438
Lines 133268 110610 -22658
Branches 16034 13906 -2128
=============================================
- Hits 91122 53385 -37737
- Misses 35093 51693 +16600
+ Partials 7053 5532 -1521
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <71.79%> (-15.72%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <71.79%> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1492 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138904924
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.87%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 45.87% -22.51%
+ Complexity 27573 15211 -12362
=============================================
Files 2433 1966 -467
Lines 133268 108042 -25226
Branches 16034 13361 -2673
=============================================
- Hits 91122 49560 -41562
- Misses 35093 53304 +18211
+ Partials 7053 5178 -1875
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <71.79%> (-12.50%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1557 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138880459
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 54.17% -14.20%
+ Complexity 27573 12190 -15383
=============================================
Files 2433 1423 -1010
Lines 133268 70049 -63219
Branches 16034 7804 -8230
=============================================
- Hits 91122 37952 -53170
+ Misses 35093 28733 -6360
+ Partials 7053 3364 -3689
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `55.84% <100.00%> (-35.07%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `38.98% <ø> (-32.21%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1771 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138959942
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.38%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.38% -0.99%
+ Complexity 27573 27200 -373
============================================
Files 2433 2434 +1
Lines 133268 133268
Branches 16034 16030 -4
============================================
- Hits 91122 89808 -1314
- Misses 35093 36319 +1226
- Partials 7053 7141 +88
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <76.92%> (-3.86%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <71.79%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [188 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3795599119
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestUpdateSchemaEvolution.java:
##########
@@ -122,7 +124,7 @@ private void assertSchemaEvolutionOnUpdateResult(WriteStatus insertResult, Hoodi
jsc.parallelize(Arrays.asList(1)).map(x -> {
Executable executable = () -> {
HoodieWriteMergeHandle mergeHandle = new HoodieWriteMergeHandle(updateTable.getConfig(), "101", updateTable,
- updateRecords.iterator(), updateRecords.get(0).getPartitionPath(), insertResult.getFileId(), supplier, Option.empty());
+ MergeContext.create(updateRecords.size(), (Iterator) updateRecords.iterator()), updateRecords.get(0).getPartitionPath(), insertResult.getFileId(), supplier, Option.empty());
Review Comment:
Addressed in 10279a3b98f4. The lists come out of the test data generators as raw List<HoodieRecord>, so typing them upstream is not possible; the cast is now centralized in HoodieClientTestUtils.toTypedRecordIterator with a scoped @SuppressWarnings, and the call sites no longer cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5293983781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
}, {
"hash" : "a776077238124c31dbdab4a08a51af68a83dec84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309",
"triggerID" : "a776077238124c31dbdab4a08a51af68a83dec84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* cba938e5d68f36a45e574a189ff748c65e159cbd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291)
* a776077238124c31dbdab4a08a51af68a83dec84 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164839081
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 61.23% -7.30%
+ Complexity 27968 24884 -3084
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 82336 -9802
- Misses 35054 45235 +10181
+ Partials 7264 6899 -365
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `85.91% <ø> (-2.12%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [530 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164858255
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.69767%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.81%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 65.81% -2.72%
+ Complexity 27968 26746 -1222
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 88501 -3637
- Misses 35054 38618 +3564
- Partials 7264 7351 +87
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <71.79%> (-16.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <71.79%> (-0.54%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `64.40% <ø> (-6.78%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `70.87% <100.00%> (-10.20%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `35.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [362 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164910966
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.59%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.59% -0.94%
+ Complexity 27968 27559 -409
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90889 -1249
- Misses 35054 36291 +1237
- Partials 7264 7290 +26
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <76.92%> (-3.73%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [148 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165279499
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.12%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.12% -20.41%
+ Complexity 27968 16366 -11602
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53544 -38594
- Misses 35054 52114 +17060
+ Partials 7264 5609 -1655
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.30% <71.79%> (-15.47%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165379386
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.69%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.69% -0.84%
+ Complexity 27968 27623 -345
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 91026 -1112
- Misses 35054 36110 +1056
- Partials 7264 7334 +70
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <76.92%> (-3.73%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [141 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165386063
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.49%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 68.49% -0.04%
+ Complexity 27968 27939 -29
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 92100 -38
- Misses 35054 35093 +39
- Partials 7264 7277 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <82.05%> (-0.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [27 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165368038
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 66c0950dc3e42f9438bb21d4952039389e97d4dc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973)
* 569d6b50ee183036b43bcb939ff8c938b6fbc1e1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138967784
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.53%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.53% -0.85%
+ Complexity 27573 27253 -320
============================================
Files 2433 2434 +1
Lines 133268 133282 +14
Branches 16034 16032 -2
============================================
- Hits 91122 90007 -1115
- Misses 35093 36156 +1063
- Partials 7053 7119 +66
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <76.92%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138965093
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.47%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.47% -0.90%
+ Complexity 27573 27230 -343
============================================
Files 2433 2434 +1
Lines 133268 133282 +14
Branches 16034 16032 -2
============================================
- Hits 91122 89937 -1185
- Misses 35093 36227 +1134
- Partials 7053 7118 +65
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <76.92%> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <71.79%> (-0.06%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138957579
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.33%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.37% 67.33% -1.04%
+ Complexity 27573 27181 -392
============================================
Files 2433 2434 +1
Lines 133268 133268
Branches 16034 16030 -4
============================================
- Hits 91122 89741 -1381
- Misses 35093 36391 +1298
- Partials 7053 7136 +83
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <65.11%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <76.92%> (-3.86%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <71.79%> (-0.28%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `75.72% <100.00%> (-5.34%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [199 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5293431354
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
}, {
"hash" : "a776077238124c31dbdab4a08a51af68a83dec84",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a776077238124c31dbdab4a08a51af68a83dec84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* cba938e5d68f36a45e574a189ff748c65e159cbd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291)
* a776077238124c31dbdab4a08a51af68a83dec84 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5295474752
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
}, {
"hash" : "a776077238124c31dbdab4a08a51af68a83dec84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309",
"triggerID" : "a776077238124c31dbdab4a08a51af68a83dec84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* a776077238124c31dbdab4a08a51af68a83dec84 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5291234661
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 150896db46eda5fdfc61b2ff6229e8a96fa62df6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146)
* cba938e5d68f36a45e574a189ff748c65e159cbd Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5314774456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
}, {
"hash" : "a776077238124c31dbdab4a08a51af68a83dec84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309",
"triggerID" : "a776077238124c31dbdab4a08a51af68a83dec84",
"triggerType" : "PUSH"
}, {
"hash" : "e73a493d9b408824893afd88099463644795d410",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e73a493d9b408824893afd88099463644795d410",
"triggerType" : "PUSH"
}, {
"hash" : "46baba50d3ab59c6fb67b80534de8a3ebd264f5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46baba50d3ab59c6fb67b80534de8a3ebd264f5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* a776077238124c31dbdab4a08a51af68a83dec84 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309)
* e73a493d9b408824893afd88099463644795d410 UNKNOWN
* 46baba50d3ab59c6fb67b80534de8a3ebd264f5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5314935029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16291",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
}, {
"hash" : "a776077238124c31dbdab4a08a51af68a83dec84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309",
"triggerID" : "a776077238124c31dbdab4a08a51af68a83dec84",
"triggerType" : "PUSH"
}, {
"hash" : "e73a493d9b408824893afd88099463644795d410",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e73a493d9b408824893afd88099463644795d410",
"triggerType" : "PUSH"
}, {
"hash" : "46baba50d3ab59c6fb67b80534de8a3ebd264f5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46baba50d3ab59c6fb67b80534de8a3ebd264f5c",
"triggerType" : "PUSH"
}, {
"hash" : "10279a3b98f495f61932595c19f8429bcb83c5eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10279a3b98f495f61932595c19f8429bcb83c5eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* a776077238124c31dbdab4a08a51af68a83dec84 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16309)
* e73a493d9b408824893afd88099463644795d410 UNKNOWN
* 46baba50d3ab59c6fb67b80534de8a3ebd264f5c UNKNOWN
* 10279a3b98f495f61932595c19f8429bcb83c5eb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138785343
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.66667%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.16%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28f6dd1`](https://app.codecov.io/gh/apache/hudi/commit/28f6dd1e57bec85b18189965a44764ac5ddc3d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (28f6dd1). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (28f6dd1) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.37% 45.16% -23.22%
+ Complexity 27573 8461 -19112
=============================================
Files 2433 1194 -1239
Lines 133268 61361 -71907
Branches 16034 6553 -9481
=============================================
- Hits 91122 27713 -63409
+ Misses 35093 30635 -4458
+ Partials 7053 3013 -4040
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <86.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <100.00%> (-41.56%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `35.59% <ø> (-35.60%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `50.48% <100.00%> (-30.59%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `49.29% <ø> (-38.74%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `25.00% <100.00%> (-25.00%)` | :arrow_down: |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `90.13% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2028 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4138735539
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164779980
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.75%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 45.75% -22.78%
+ Complexity 27968 15233 -12735
=============================================
Files 2440 1968 -472
Lines 134456 108659 -25797
Branches 16226 13504 -2722
=============================================
- Hits 92138 49713 -42425
- Misses 35054 53710 +18656
+ Partials 7264 5236 -2028
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <71.79%> (-12.84%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164818269
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.15%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (66c0950). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (66c0950) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.15% -20.37%
+ Complexity 27968 16378 -11590
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53586 -38552
- Misses 35054 52084 +17030
+ Partials 7264 5597 -1667
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <71.79%> (-15.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164901549
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.57%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 67.57% -0.96%
+ Complexity 27968 27553 -415
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 90864 -1274
- Misses 35054 36315 +1261
- Partials 7264 7291 +27
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <76.92%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <71.79%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `67.79% <ø> (-3.39%)` | :arrow_down: |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `76.21% <100.00%> (-4.86%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4164929472
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.52%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`66c0950`](https://app.codecov.io/gh/apache/hudi/commit/66c0950dc3e42f9438bb21d4952039389e97d4dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.52%
Complexity 27968 27968
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92148 +10
- Misses 35054 35057 +3
- Partials 7264 7265 +1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <84.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <82.05%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `58.33% <100.00%> (+8.33%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165273867
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.05%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.05% -20.47%
+ Complexity 27968 16342 -11626
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53472 -38666
- Misses 35054 52182 +17128
+ Partials 7264 5613 -1651
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.69% <71.79%> (-15.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1503 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165275350
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.05%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (569d6b5). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (35e2bbf) | HEAD (569d6b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=============================================
- Coverage 68.52% 48.05% -20.47%
+ Complexity 27968 16342 -11626
=============================================
Files 2440 1997 -443
Lines 134456 111267 -23189
Branches 16226 14060 -2166
=============================================
- Hits 92138 53472 -38666
- Misses 35054 52182 +17128
+ Partials 7264 5613 -1651
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.69% <71.79%> (-15.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <71.79%> (-12.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `42.37% <ø> (-28.82%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.44% <100.00%> (-12.63%)` | :arrow_down: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <ø> (-3.53%)` | :arrow_down: |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `50.00% <100.00%> (ø)` | |
| [...le/action/commit/BaseJavaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseJavaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0Jhc2VKYXZhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `72.64% <100.00%> (+0.23%)` | :arrow_up: |
| [...udi/table/action/commit/JavaUpsertPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FJavaUpsertPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tbWl0L0phdmFVcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `91.44% <100.00%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1503 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4165381616
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.49%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
============================================
- Coverage 68.52% 68.49% -0.04%
+ Complexity 27968 27939 -29
============================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
============================================
- Hits 92138 92099 -39
- Misses 35054 35094 +40
- Partials 7264 7277 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <82.05%> (-0.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-4196912022
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `93.02326%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.53%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`569d6b5`](https://app.codecov.io/gh/apache/hudi/commit/569d6b50ee183036b43bcb939ff8c938b6fbc1e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 16 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/HoodieSortedMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...deltacommit/BaseJavaDeltaCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fdeltacommit%2FBaseJavaDeltaCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vZGVsdGFjb21taXQvQmFzZUphdmFEZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18396 +/- ##
=========================================
Coverage 68.52% 68.53%
- Complexity 27968 27970 +2
=========================================
Files 2440 2441 +1
Lines 134456 134470 +14
Branches 16226 16228 +2
=========================================
+ Hits 92138 92159 +21
+ Misses 35054 35047 -7
Partials 7264 7264
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <72.09%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <86.66%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <84.84%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <82.05%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <71.79%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18396/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.36% <71.79%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [.../org/apache/hudi/io/HoodieAbstractMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAbstractMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFic3RyYWN0TWVyZ2VIYW5kbGUuamF2YQ==) | `83.63% <100.00%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/hudi/io/HoodieConcatHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieConcatHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUNvbmNhdEhhbmRsZS5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...a/org/apache/hudi/io/HoodieMergeHandleFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlRmFjdG9yeS5qYXZh) | `71.18% <ø> (ø)` | |
| [...apache/hudi/io/HoodieMergeHandleWithChangeLog.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieMergeHandleWithChangeLog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlV2l0aENoYW5nZUxvZy5qYXZh) | `62.85% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.55% <100.00%> (+0.48%)` | :arrow_up: |
| [...src/main/java/org/apache/hudi/io/MergeContext.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FMergeContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL01lcmdlQ29udGV4dC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <ø> (ø)` | |
| [...rg/apache/hudi/table/action/commit/BucketInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBucketInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQnVja2V0SW5mby5qYXZh) | `75.00% <100.00%> (+25.00%)` | :arrow_up: |
| [.../hudi/io/FlinkFileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFlinkFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtGaWxlR3JvdXBSZWFkZXJCYXNlZE1lcmdlSGFuZGxlLmphdmE=) | `55.26% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18396?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5291185545
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
}, {
"hash" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cba938e5d68f36a45e574a189ff748c65e159cbd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 150896db46eda5fdfc61b2ff6229e8a96fa62df6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16146)
* cba938e5d68f36a45e574a189ff748c65e159cbd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18396:
URL: https://github.com/apache/hudi/pull/18396#issuecomment-5208067566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f6dd1e57bec85b18189965a44764ac5ddc3d63",
"triggerType" : "PUSH"
}, {
"hash" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12971",
"triggerID" : "290517350672bd44bac4f24fe00e81f268d1b3ef",
"triggerType" : "PUSH"
}, {
"hash" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12973",
"triggerID" : "66c0950dc3e42f9438bb21d4952039389e97d4dc",
"triggerType" : "PUSH"
}, {
"hash" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975",
"triggerID" : "569d6b50ee183036b43bcb939ff8c938b6fbc1e1",
"triggerType" : "PUSH"
}, {
"hash" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "150896db46eda5fdfc61b2ff6229e8a96fa62df6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f6dd1e57bec85b18189965a44764ac5ddc3d63 UNKNOWN
* 569d6b50ee183036b43bcb939ff8c938b6fbc1e1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12975)
* 150896db46eda5fdfc61b2ff6229e8a96fa62df6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3731062106
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/MergeContext.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io;
+
+import org.apache.hudi.common.model.HoodieRecord;
+
+import java.util.Iterator;
+
+/**
+ * Context for merge handle creation, carrying incoming data and characteristics
+ */
+public class MergeContext<T> {
+
+ /**
+ * The estimated number of incoming update and delete records to merge
+ * A value of -1 means unknown.
+ */
+ private final long numIncomingUpdates;
Review Comment:
🤖 nit: the same count flows through the codebase under two names — `numUpdates` in `BucketInfo` and the `handleUpdate` parameter, but `numIncomingUpdates` here and in `HoodieAbstractMergeHandle`. Could you pick one (e.g. `numUpdates`) and use it consistently? A future reader tracing the value from the partitioner through to the handle has to figure out these are the same thing.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Pass the number of updates from workload profiling through to merge handle [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3036299291
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java:
##########
@@ -392,30 +404,47 @@ private HoodieWriteConfig.Builder makeHoodieClientConfigBuilder() {
@Test
void testMapAndListBasedSparkBucketInfoGetter() {
- List<BucketInfo> bucketInfos = Arrays.asList(new BucketInfo(BucketType.UPDATE, "bucket1", "partition1"),
- new BucketInfo(BucketType.UPDATE, "bucket2", "partition2"));
+ List<BucketInfo> bucketInfos = Arrays.asList(new BucketInfo(BucketType.UPDATE, "bucket1", "partition1", 42),
+ new BucketInfo(BucketType.UPDATE, "bucket2", "partition2", 99));
Map<Integer, BucketInfo> bucketInfoMap = new HashMap<>();
bucketInfoMap.put(0, bucketInfos.get(0));
bucketInfoMap.put(1, bucketInfos.get(1));
MapBasedSparkBucketInfoGetter getter = new MapBasedSparkBucketInfoGetter(bucketInfoMap);
ListBasedSparkBucketInfoGetter listGetter = new ListBasedSparkBucketInfoGetter(bucketInfos);
assertEquals(bucketInfos.get(0), getter.getBucketInfo(0));
assertEquals(bucketInfos.get(0), listGetter.getBucketInfo(0));
+ assertEquals(42, getter.getBucketInfo(0).getNumUpdates());
+ assertEquals(42, listGetter.getBucketInfo(0).getNumUpdates());
assertEquals(bucketInfos.get(1), getter.getBucketInfo(1));
assertEquals(bucketInfos.get(1), listGetter.getBucketInfo(1));
+ assertEquals(99, getter.getBucketInfo(1).getNumUpdates());
+ assertEquals(99, listGetter.getBucketInfo(1).getNumUpdates());
+ }
+
+ @Test
+ void testBucketInfoDefaultNumUpdates() {
+ BucketInfo bucketInfo = new BucketInfo(BucketType.UPDATE, "file1", "partition1");
+ assertEquals(-1L, bucketInfo.getNumUpdates(), "Default numUpdates should be -1 (unknown)");
+
+ BucketInfo bucketInfoWithUpdates = new BucketInfo(BucketType.UPDATE, "file1", "partition1", 500);
+ assertEquals(500, bucketInfoWithUpdates.getNumUpdates());
+
+ BucketInfo insertBucket = new BucketInfo(BucketType.INSERT, "file2", "partition1", 0);
+ assertEquals(0, insertBucket.getNumUpdates());
Review Comment:
_⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Expected result: no output from non-test sources unless an UPDATE bucket is intentionally unknown.
python - <<'PY'
from pathlib import Path
def iter_calls(text, needle="new BucketInfo("):
i = 0
while True:
start = text.find(needle, i)
if start < 0:
return
j = start + len(needle)
depth = 1
in_str = None
while j < len(text) and depth:
ch = text[j]
if in_str:
if ch == '\\':
j += 2
continue
if ch == in_str:
in_str = None
else:
if ch in ("'", '"'):
in_str = ch
elif ch == '(':
depth += 1
elif ch == ')':
depth -= 1
j += 1
yield start, text[start:j]
i = j
def arg_count(call):
args = call[call.find('(') + 1:-1]
depth = 0
in_str = None
commas = 0
i = 0
while i < len(args):
ch = args[i]
if in_str:
if ch == '\\':
i += 2
continue
if ch == in_str:
in_str = None
else:
if ch in ("'", '"'):
in_str = ch
elif ch in "([{<":
depth += 1
elif ch in ")]}>":
depth -= 1
elif ch == ',' and depth == 0:
commas += 1
i += 1
return 0 if not args.strip() else commas + 1
for path in Path('.').rglob('*.java'):
spath = str(path).replace("\\", "/")
if "/src/test/" in spath:
continue
text = path.read_text(errors='ignore')
for start, call in iter_calls(text):
if "BucketType.UPDATE" in call and arg_count(call) == 3:
line = text.count('\n', 0, start) + 1
print(f"{spath}:{line}: {call.replace(chr(10), ' ')}")
PY
```
Repository: yihua/hudi
Length of output: 1639
---
</details>
**Fix production UPDATE bucket sites still using 3-arg constructor.**
8 production locations still create UPDATE buckets with the 3-arg `BucketInfo` constructor, which silently defaults `numUpdates` to `-1`:
- `hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/commit/JavaUpsertPartitioner.java:123`
- `hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkBucketIndexBucketInfoGetter.java:59,63`
- `hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkMetadataTableFirstDeltaCommitActionExecutor.java:87`
- `hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/update/strategy/ConsistentBucketUpdateStrategy.java:130`
- `hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketAssigner.java:127,140,162`
Since `handleUpdate(...)` now forwards `getNumUpdates()` to `MergeContext`, these calls will bypass the signal. Pass an explicit count or document why `-1` is intentional.
<!-- fingerprinting:phantom:medusa:grasshopper:6b6b31b3-3397-49ed-ab1d-32b91559712d -->
<!-- This is an auto-generated comment by CodeRabbit -->
— *CodeRabbit* ([original](https://github.com/yihua/hudi/pull/14#discussion_r3036299135)) (source:comment#3036299135)
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -137,7 +137,7 @@ public HoodieWriteMergeHandle(HoodieWriteConfig config, String instantTime, Hood
Map<String, HoodieRecord<T>> keyToNewRecords, String partitionPath, String fileId,
HoodieBaseFile dataFileToBeMerged, TaskContextSupplier taskContextSupplier,
Option<BaseKeyGenerator> keyGeneratorOpt) {
- super(config, instantTime, hoodieTable, partitionPath, fileId, taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt,
+ super(config, instantTime, hoodieTable, MergeContext.create(Collections.emptyIterator()), partitionPath, fileId, taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt,
// preserveMetadata is disabled by default for MDT but enabled otherwise
!HoodieTableMetadata.isMetadataTable(config.getBasePath()));
this.keyToNewRecords = keyToNewRecords;
Review Comment:
<a href="#"><img alt="P2" src="https://greptile-static-assets.s3.amazonaws.com/badges/p2.svg?v=7" align="top"></a> **`MergeContext.create(Collections.emptyIterator())` loses `numIncomingUpdates` in MDT path**
In the internal constructor used for Metadata Table (MDT) writes, a fresh `MergeContext` with no iterator and `numIncomingUpdates = -1L` is created, even though `keyToNewRecords` (passed in from the caller) was already populated. This is correct — the MDT path passes a pre-built map — but it's worth noting that this path will always have `numIncomingUpdates = -1`. If the MDT path ever needs accurate counts in the future, callers will need to be updated.
This is not an immediate bug, but the comment or Javadoc on this constructor could be improved to make this "always -1" semantic explicit for maintainers.
— *Greptile* ([original](https://github.com/yihua/hudi/pull/14#discussion_r3036291940)) (source:comment#3036291940)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org