You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/03/05 20:46:28 UTC

[GitHub] [incubator-livy] squito commented on issue #284: [LIVY-752] Fix implementation of limits on connections.

squito commented on issue #284: [LIVY-752] Fix implementation of limits on connections.
URL: https://github.com/apache/incubator-livy/pull/284#issuecomment-595438421
 
 
   I think the helper `withinLimits()` is no longer used.
   
   without testing for concurrency, could you at least add a basic unit test that the limits are enforced, say on `anyViolations()`?  (given that the logic was entirely backwards before, a unit test seems like it would help here.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services