You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2019/06/14 23:15:00 UTC
[jira] [Updated] (DIRSERVER-1916) Don't drop 'top' from ObjectClass index, it's never present in the BTree

     [ https://issues.apache.org/jira/browse/DIRSERVER-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-1916:
-----------------------------------------
    Description: 
There is no need to call the partition specific code to drop the 'top' ObjectClass, it's not managed by any index. The following code in AbstractBTreePartition need to be changed :

{code:java}
            // Update the ObjectClass index
            for ( Value<?> value : objectClass )
            {
                objectClassIdx.drop( value.getString(), id );
            }
{code}

This is the same thing for modifyAdd() :

{code:java}
            for ( Value<?> value : mods )
            {
                objectClassIdx.add( ( String ) value.getNormValue(), id );
            }
{code}

and modifyReplace() :

{code:java}
            for ( Value<?> value : entry.get( OBJECT_CLASS_AT ) )
            {
                objectClassIdx.drop( ( String ) value.getNormValue(), id );
            }
{code}

for modifyRemove() :

{code:java}
                for ( Value<?> objectClass : entry.get( OBJECT_CLASS_AT ) )
                {
                    objectClassIdx.drop( ( String ) objectClass.getNormValue(), id );
                }
{code}

and

{code:java}
                for ( Value<?> value : mods )
                {
                    objectClassIdx.drop( ( String ) value.getNormValue(), id );
                }
{code}


  was:
There is no need to call the partition specific code to drop the 'top' ObjectClass, it's not managed by any index. The following code in AbstractBTreePartition need to be changed :

            // Update the ObjectClass index
            for ( Value<?> value : objectClass )
            {
                objectClassIdx.drop( value.getString(), id );
            }

This is the same thing for modifyAdd() :

            for ( Value<?> value : mods )
            {
                objectClassIdx.add( ( String ) value.getNormValue(), id );
            }

and modifyReplace() :

            for ( Value<?> value : entry.get( OBJECT_CLASS_AT ) )
            {
                objectClassIdx.drop( ( String ) value.getNormValue(), id );
            }

for modifyRemove() :

                for ( Value<?> objectClass : entry.get( OBJECT_CLASS_AT ) )
                {
                    objectClassIdx.drop( ( String ) objectClass.getNormValue(), id );
                }

and

                for ( Value<?> value : mods )
                {
                    objectClassIdx.drop( ( String ) value.getNormValue(), id );
                }



> Don't drop 'top' from ObjectClass index, it's never present in the BTree
> ------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1916
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1916
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-M15
>            Reporter: Emmanuel Lecharny
>            Priority: Major
>             Fix For: 2.0.0-RC1
>
>
> There is no need to call the partition specific code to drop the 'top' ObjectClass, it's not managed by any index. The following code in AbstractBTreePartition need to be changed :
> {code:java}
>             // Update the ObjectClass index
>             for ( Value<?> value : objectClass )
>             {
>                 objectClassIdx.drop( value.getString(), id );
>             }
> {code}
> This is the same thing for modifyAdd() :
> {code:java}
>             for ( Value<?> value : mods )
>             {
>                 objectClassIdx.add( ( String ) value.getNormValue(), id );
>             }
> {code}
> and modifyReplace() :
> {code:java}
>             for ( Value<?> value : entry.get( OBJECT_CLASS_AT ) )
>             {
>                 objectClassIdx.drop( ( String ) value.getNormValue(), id );
>             }
> {code}
> for modifyRemove() :
> {code:java}
>                 for ( Value<?> objectClass : entry.get( OBJECT_CLASS_AT ) )
>                 {
>                     objectClassIdx.drop( ( String ) objectClass.getNormValue(), id );
>                 }
> {code}
> and
> {code:java}
>                 for ( Value<?> value : mods )
>                 {
>                     objectClassIdx.drop( ( String ) value.getNormValue(), id );
>                 }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org