You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Matteo Bertozzi (JIRA)" <ji...@apache.org> on 2013/05/24 19:14:21 UTC

[jira] [Commented] (HBASE-8614) Handle possible NullPointerException in FSUtils#create(FileSystem fs, Path path, FsPermission perm, InetSocketAddress[] favoredNodes)

    [ https://issues.apache.org/jira/browse/HBASE-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666472#comment-13666472 ] 

Matteo Bertozzi commented on HBASE-8614:
----------------------------------------

{code}
+} catch (NullPointerException npe) {
+  LOG.debug("Ignoring (most likely Reflection related exception) " + npe);       
{code}
does this means that if the create() overload doesn't exists, we don't create the file and we fail silently?
                
> Handle possible NullPointerException in FSUtils#create(FileSystem fs, Path path, FsPermission perm, InetSocketAddress[] favoredNodes)
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8614
>                 URL: https://issues.apache.org/jira/browse/HBASE-8614
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: 8614-v1.txt
>
>
> Running test suite on hadoop 2.0, I saw the following test failure:
> {code}
> testFavoredNodes(org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes)  Time elapsed: 0.106 sec  <<< ERROR!
> org.apache.hadoop.hbase.exceptions.DroppedSnapshotException: region: table,rrr,1369355298031.1fdb1b446b02b497f0869a08adad7745.
>         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1568)
>         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1429)
>         at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1347)
>         at org.apache.hadoop.hbase.MiniHBaseCluster.flushcache(MiniHBaseCluster.java:531)
>         at org.apache.hadoop.hbase.HBaseTestingUtility.flush(HBaseTestingUtility.java:961)
>         at org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes.testFavoredNodes(TestRegionFavoredNodes.java:132)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>         at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>         at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
>         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
>         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>         at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
>         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
>         at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
>         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
>         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>         at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
>         at org.junit.runners.Suite.runChild(Suite.java:127)
>         at org.junit.runners.Suite.runChild(Suite.java:26)
>         at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>         at java.lang.Thread.run(Thread.java:662)
> Caused by: java.io.IOException: java.lang.NullPointerException
>         at org.apache.hadoop.hbase.util.FSUtils.create(FSUtils.java:293)
>         at org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.createOutputStream(AbstractHFileWriter.java:268)
>         at org.apache.hadoop.hbase.io.hfile.HFile$WriterFactory.create(HFile.java:427)
>         at org.apache.hadoop.hbase.regionserver.StoreFile$Writer.<init>(StoreFile.java:791)
>         at org.apache.hadoop.hbase.regionserver.StoreFile$Writer.<init>(StoreFile.java:733)
>         at org.apache.hadoop.hbase.regionserver.StoreFile$WriterBuilder.build(StoreFile.java:671)
>         at org.apache.hadoop.hbase.regionserver.HStore.createWriterInTmp(HStore.java:799)
>         at org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>         at org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:704)
>         at org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:1813)
>         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1543)
>         ... 33 more
> Caused by: java.lang.NullPointerException
>         at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1306)
>         at org.apache.hadoop.hdfs.DistributedFileSystem.create(DistributedFileSystem.java:283)
> {code}
> DistributedFileSystem#create() which supports favoredNodes parameter threw NullPointerException.
> We should handle the NullPointerException and fall back to conventional DistributedFileSystem#create()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira