You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/10 08:29:19 UTC
[GitHub] [rocketmq-client-go] 0daypwn opened a new pull request, #934: [ISSUE #933] fix retry topic and namespace topic block
0daypwn opened a new pull request, #934:
URL: https://github.com/apache/rocketmq-client-go/pull/934
## What is the purpose of the change
close #933
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block
Posted by GitBox <gi...@apache.org>.
0daypwn commented on PR #934:
URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1274242283
map is not thread safe, so should add RWMutex.
The design is too complicated. Maybe there's a better way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] 0daypwn closed pull request #934: [ISSUE #933] fix retry topic and namespace topic block
Posted by "0daypwn (via GitHub)" <gi...@apache.org>.
0daypwn closed pull request #934: [ISSUE #933] fix retry topic and namespace topic block
URL: https://github.com/apache/rocketmq-client-go/pull/934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on PR #934:
URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1278669814
@0daypwn , hi, it seems have conflicts after PR #944 merged, could you pls fix it and and have a test after the crCh initialized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on PR #934:
URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1288978510
<img width="851" alt="截屏2022-10-24 20 42 32" src="https://user-images.githubusercontent.com/3734319/197527942-f39edb03-8db1-402a-91ad-acb0a90ba2d5.png">
@0daypwn pls resolve the conflicts first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block
Posted by GitBox <gi...@apache.org>.
0daypwn commented on PR #934:
URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1278705755
The purpose of these two is the same.
but the pc.crCh Map may be read and written concurrently in two places
- Subscribe
- consumeMessageCurrently
it may cause panic.
@ShannonDing @NeonToo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org