[jira] [Commented] (FINERACT-1241) Elastic web hook

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224076#comment-17224076 ] 

Michael Vorburger commented on FINERACT-1241:
---------------------------------------------

The PR https://github.com/apache/fineract/pull/1466 was merged without a green build, and causes all subsequent PRs to fail with:

{noformat}HookIntegrationTest > shouldSendOfficeCreationNotification() FAILED

    org.opentest4j.AssertionFailedError: Equality check for created officeId and hook received payload officeId ==> expected: <10> but was: <null>

        at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)

        at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

        at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)

        at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:569)

        at org.apache.fineract.integrationtests.HookIntegrationTest.shouldSendOfficeCreationNotification(HookIntegrationTest.java:83){noformat}

See e.g. https://travis-ci.org/github/apache/fineract/builds/740238779 and https://travis-ci.org/github/apache/fineract/builds/740162646 and https://travis-ci.org/github/apache/fineract/builds/740114540 and https://travis-ci.org/github/apache/fineract/builds/739657492 and https://travis-ci.org/github/apache/fineract/builds/740114540.

I've thus taken the typically somewhat unusual step and in the interest of unblocking the community made the decision to REVERT the merge of that PR. I'm hoping that the contributor (Manoj) and Committer (Avik) involved here that this is the best first short term step, and does not discourage from raising a new PR, getting it to build green, and then re-merge. Hope this process makes sense to you as well?

> Elastic web hook
> ----------------
>
>                 Key: FINERACT-1241
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1241
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Manoj
>            Assignee: Michael Vorburger
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Elastic web hook to push events to elastic search for analytics purpose.
> Extend the Fieract hooks to include elastic push feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)