DefaultJspCompilerAdapter change in 1.5 branch breaks Tomcat

[Stefan Bodewig <bo...@apache.org>]

Steve, Keith,

could you please look at 
<http://cvs.apache.org/~bodewig/gump/20020522/jakarta-tomcat.html>?

When Steve changed from Commandline to CommandlineJava, Keith's
Tomcat3 precompiler has been broken.  This means it will not work in
Ant 1.5 unless Keith adapts to the new method signature at the same
time.

I think the easiest way to deal with the current issue was to merge
the 1.5 branch changes for this class into the main branch and change
Tomcat3Precompiler at the same time.

Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: DefaultJspCompilerAdapter change in 1.5 branch breaks Tomcat

[Steve Loughran <st...@iseran.com>]

----- Original Message -----
From: "Keith Wannamaker" <Ke...@Wannamaker.org>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Wednesday, May 22, 2002 6:11 AM
Subject: RE: DefaultJspCompilerAdapter change in 1.5 branch breaks Tomcat


> Stefan,
> Since these tomcat tools only work with Ant 1.5
> (JspC isn't in 1.4.1), I'll just change the tool.
> I'm a little perplexed, though, that the methods
> were pulled rather than deprecated, assuming they
> existed prior to 1.5.  (Those should be dep
> warnings we get, not compile errors :-)

probably because I didnt think anybody was using them yet, and was trying to
stablize the code. Sorry.

I am finding <jspc> a bit unreliable still; half the problem is jasper and
so out of our hands, but it is irritating that it doesnt meet my
expectations, even for predeploy validation. I am using httpunit for
post-deploy testing insteead.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: DefaultJspCompilerAdapter change in 1.5 branch breaks Tomcat

[Stefan Bodewig <bo...@apache.org>]

On Wed, 22 May 2002, Keith Wannamaker <Ke...@Wannamaker.org> wrote:

> I'll just change the tool.

If you do so before Steve's changes have been merged into the main
branch, you'll get Nag mails from the regular Gump runs (my link
pointed to my own Gump runs that use the 1.5 CVS branch of Ant).

> I'm a little perplexed, though, that the methods were pulled rather
> than deprecated, assuming they existed prior to 1.5.

The whole class hasn't been there before 1.5.  Otherwise I totally
agree with you.

Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: DefaultJspCompilerAdapter change in 1.5 branch breaks Tomcat

[Keith Wannamaker <Ke...@Wannamaker.org>]

Stefan,
Since these tomcat tools only work with Ant 1.5 
(JspC isn't in 1.4.1), I'll just change the tool.
I'm a little perplexed, though, that the methods
were pulled rather than deprecated, assuming they
existed prior to 1.5.  (Those should be dep 
warnings we get, not compile errors :-)

Keith

| -----Original Message-----
| From: Stefan Bodewig [mailto:bodewig@apache.org]
| Sent: Wednesday, May 22, 2002 4:59 AM
| To: ant-dev@jakarta.apache.org
| Subject: DefaultJspCompilerAdapter change in 1.5 branch breaks Tomcat
| 
| 
| Steve, Keith,
| 
| could you please look at 
| <http://cvs.apache.org/~bodewig/gump/20020522/jakarta-tomcat.html>?
| 
| When Steve changed from Commandline to CommandlineJava, Keith's
| Tomcat3 precompiler has been broken.  This means it will not work in
| Ant 1.5 unless Keith adapts to the new method signature at the same
| time.
| 
| I think the easiest way to deal with the current issue was to merge
| the 1.5 branch changes for this class into the main branch and change
| Tomcat3Precompiler at the same time.
| 
| Stefan
| 
| --
| To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
| For additional commands, e-mail: <ma...@jakarta.apache.org>
| 
| 

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>