[jira] [Resolved] (CALCITE-4158) In generated SQL, "*" should be followed by space

["Julian Hyde (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-4158.
----------------------------------
    Resolution: Fixed

Fixed in [8430023f|https://github.com/apache/calcite/commit/8430023f4616a9b239641b59420f56ecc3fa3e40]; thanks for the PR, [~nobigo]!

> In generated SQL, "*" should be followed by space
> -------------------------------------------------
>
>                 Key: CALCITE-4158
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4158
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.23.0
>            Reporter: Roman Churganov
>            Assignee: duan xiong
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Printing a query with the following parameters  gives a result
> {noformat}SELECT *FROM TAB{noformat}
> Note: no space between "*" and "FROM".
> {code}
> val parser = SqlParser.create("",
>   SqlParser.configBuilder()
>     .setCaseSensitive(false)
>    .setParserFactory(SqlParserImpl.FACTORY)
>    .setQuoting(Quoting.DOUBLE_QUOTE)
>     .build())
> val query = parser.parseQuery("select * from tab")
> val actual = query.toSqlString { c: SqlWriterConfig ->
>     c.withDialect(PostgresqlSqlDialect.DEFAULT)
>       .withAlwaysUseParentheses(false)
>       .withSelectListItemsOnSeparateLines(false)
>       .withCaseClausesOnNewLines(false)
>       .withQuoteAllIdentifiers(false)
>       .withIndentation(0)
>       .withClauseStartsLine(false)
>       .withFromFolding(SqlWriterConfig.LineFolding.WIDE)
>       .withSelectFolding(SqlWriterConfig.LineFolding.WIDE)
>       .withLineFolding(SqlWriterConfig.LineFolding.WIDE)
>    }.sql
> println(actual)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)