You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/25 18:04:06 UTC
[GitHub] [hadoop-ozone] swagle opened a new pull request #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
swagle opened a new pull request #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604
## What changes were proposed in this pull request?
Fixed the HealthyPipelineSafeModeExitRule to wait on pipeline healthy state implying, the pipeline leader is available upon OPEN, fixed related tests.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3038
## How was this patch tested?
Ran related integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288561
+1. I don't see there is CI checks. But the compile and related UTs all passed locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi removed a comment on issue #604:
HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader
in the HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
ChenSammi removed a comment on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288633
/Retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi edited a comment on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288561
I don't see there is CI checks. But the compile and related UTs all passed locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288633
/Retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288974
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] swagle edited a comment on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
swagle edited a comment on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591700541
Thanks @ChenSammi for review and @adoroszlai for re-running the test.
Failure 1: Seems miniOzone cluster flakiness, hard to determine why that failed
Failure 2: Leader seems to not be available when the test expected it to be, made a change to the test to a) wait for a multiple of leader election timeout and then changed the exit criteria to wait for 20 seconds until the leader is verified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] swagle commented on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
swagle commented on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591700541
Thanks @ChenSammi for review and @adoroszlai for re-running the test.
Failure 1: Seems miniOzone cluster flakiness, hard to determine why that failed
Failure 2: Leader seems to not be available when the test expected it to be, made a change to test to a) wait for a multiple of leader election timeout and then changed the exit criteria to wait for 20 seconds until the leader is verified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi edited a comment on issue #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288561
+1. I don't see there is CI checks. But the compile and related UTs all passed locally. Will wait for the CI result before merge the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on issue #604:
HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader
in the HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604#issuecomment-591288749
No such command. `Retest` Available commands:
* /**help** : Show all the available comment commands
* /**label** : add new label to the issue: `/label <label>`
* /**pending** : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending <reason>`
* /**ready** : Dismiss all the blocking reviews by github-actions bot
* /**retest** : add new empty commit to trigger new CI build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #604: HDDS-3038.
TestRatisPipelineLeader fails since we no longer wait for leader in the
HealthyPipelineSafeModeExitRule.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #604: HDDS-3038. TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule.
URL: https://github.com/apache/hadoop-ozone/pull/604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org