You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2014/05/01 17:28:07 UTC

[GitHub] spark pull request: [SPARK-1672][WIP] Separate partitioning in ALS

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/593#discussion_r12191694
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
    @@ -105,14 +106,15 @@ class ALS private (
        * Constructs an ALS instance with default parameters: {numBlocks: -1, rank: 10, iterations: 10,
        * lambda: 0.01, implicitPrefs: false, alpha: 1.0}.
        */
    -  def this() = this(-1, 10, 10, 0.01, false, 1.0)
    +  def this() = this(-1, -1, 10, 10, 0.01, false, 1.0)
     
       /**
        * Set the number of blocks to parallelize the computation into; pass -1 for an auto-configured
        * number of blocks. Default: -1.
    --- End diff --
    
    Need more doc mentioning this overwrites both `numUserBlocks` and `numProductBlocks`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---