[jira] [Commented] (FLINK-4194) Implement isEndOfStream() for KinesisDeserializationSchema

["Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15461269#comment-15461269 ] 

Tzu-Li (Gordon) Tai commented on FLINK-4194:
--------------------------------------------

On second thought, I think we ought to discuss whether or not adding the function back to {{KinesisDeserializationSchema}} and breaking user code is a good idea now, since the Kinesis connector is now in a released version and would need a migration plan. Its not a highly requested feature at the moment, so I would say it is currently not worth the effort. Perhaps a good time to add this back is when it is actually possible to "stop" parallel consumption across the subtasks with an atomic checkpoint-and-stop, so an {{isEndOfStream()}} behaviour can be truly defined.

What do you think, [~rmetzger]?

> Implement isEndOfStream() for KinesisDeserializationSchema
> ----------------------------------------------------------
>
>                 Key: FLINK-4194
>                 URL: https://issues.apache.org/jira/browse/FLINK-4194
>             Project: Flink
>          Issue Type: New Feature
>          Components: Kinesis Connector
>            Reporter: Robert Metzger
>            Assignee: Tzu-Li (Gordon) Tai
>             Fix For: 1.2.0
>
>
> **Original JIRA title: KinesisDeserializationSchema.isEndOfStream() is never called. The corresponding part of the code has been commented out with reference to this JIRA.**
> The Kinesis connector does not respect the {{KinesisDeserializationSchema.isEndOfStream()}} method.
> The purpose of this method is to stop consuming from a source, based on input data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)