You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by traflm <gi...@git.apache.org> on 2016/12/21 01:33:12 UTC
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
GitHub user traflm opened a pull request:
https://github.com/apache/incubator-trafodion/pull/883
[TRAFODION-2403] update sql reference manual about REGEXP function
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/incubator-trafodion TRAFODION-2403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #883
----
commit 49945da762ef47011b0e19a72b52ff18c27477d3
Author: Liu Ming <ov...@sina.com>
Date: 2016-12-21T01:22:57Z
[TRAFODION-2403] update sql reference manual about REGEXP function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/883#discussion_r93460393
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -2511,6 +2511,8 @@ subquery is empty, the predicate is false.
| <<in_predicate,IN Predicate>> | Determines if a sequence of values is equal to any of the sequences of
values in a list of sequences.
| <<like_predicate,LIKE Predicate>> | Searches for character strings that match a pattern.
+| <<regexp_predicate,REGEXP Predicate>> | Searches for character strings that match a pattern, The pattern
--- End diff --
Suggested wordsmith: "Searches for character strings that match an extended regular expression."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/883#discussion_r93461525
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -3352,6 +3354,60 @@ The escape character indicates that the underscore in 'FLOPPY_DISK' is
part of the string to search for, not a wild-card character.
<<<
+[[regexp_predicate]]
+=== REGEXP Predicate
+
+Performs a pattern match of a string expression against a pattern .
+The pattern can be an extended regular expression.
+Returns 1 if expression matches pattern; otherwise it returns 0.
+If either expression or pattern is NULL, the result is NULL.
+
+[[regexp_syntax]]
+==== Syntax
+```
+match-value [NOT] REGEXP pattern
+```
+
+* `_match-value_`
++
+is a character value expression that specifies a set of strings to
+search for that match the _pattern_.
+
+* `_pattern_`
++
+is a character value expression that specifies the pattern string for
+the search in form of Regular Expression.
+The Trafodion Regular Expression is following the POSIX regular expression rules.
--- End diff --
Grammar nits. Possible wordsmith: "is a character value expression that specifies a regular expression. Trafodion regular expressions follow POSIX regular expression rules."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/883#discussion_r93706480
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -3352,6 +3353,59 @@ The escape character indicates that the underscore in 'FLOPPY_DISK' is
part of the string to search for, not a wild-card character.
<<<
+[[regexp_predicate]]
+=== REGEXP Predicate
+
+Performs a pattern match of a string expression against a pattern .
+The pattern can be an extended regular expression.
+Returns 1 if expression matches pattern; otherwise it returns 0.
+If either expression or pattern is NULL, the result is NULL.
+
+[[regexp_syntax]]
+==== Syntax
+```
+match-value [NOT] REGEXP regular-expression
+```
+
+* `_match-value_`
++
+is a character value expression that specifies a set of strings to
+search for that match the _pattern_.
+
+* `_pattern_`
++
+is a character value expression that specifies a regular expression.
+Trafodion regular expressions follow POSIX regular expression rules.
+
+
+[[using_not]]
+===== Using NOT
+
+If you specify NOT, the predicate is true if the _pattern_ does not
--- End diff --
Should say _regular-expression_ here instead of _pattern_.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/883#discussion_r93461131
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -3352,6 +3354,60 @@ The escape character indicates that the underscore in 'FLOPPY_DISK' is
part of the string to search for, not a wild-card character.
<<<
+[[regexp_predicate]]
+=== REGEXP Predicate
+
+Performs a pattern match of a string expression against a pattern .
+The pattern can be an extended regular expression.
+Returns 1 if expression matches pattern; otherwise it returns 0.
+If either expression or pattern is NULL, the result is NULL.
+
+[[regexp_syntax]]
+==== Syntax
+```
+match-value [NOT] REGEXP pattern
--- End diff --
Instead of "pattern", consider using "regular-expression" in the syntax.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/883#discussion_r93460482
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -3334,7 +3336,7 @@ trailing blank) will not be located by LIKE '%MB' but will be located by
LIKE '%MB%'.
[[like_examples]]
-=== Examples
+==== Examples
--- End diff --
Thanks for fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/883#discussion_r93706427
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -3352,6 +3353,59 @@ The escape character indicates that the underscore in 'FLOPPY_DISK' is
part of the string to search for, not a wild-card character.
<<<
+[[regexp_predicate]]
+=== REGEXP Predicate
+
+Performs a pattern match of a string expression against a pattern .
+The pattern can be an extended regular expression.
+Returns 1 if expression matches pattern; otherwise it returns 0.
+If either expression or pattern is NULL, the result is NULL.
+
+[[regexp_syntax]]
+==== Syntax
+```
+match-value [NOT] REGEXP regular-expression
+```
+
+* `_match-value_`
++
+is a character value expression that specifies a set of strings to
+search for that match the _pattern_.
+
+* `_pattern_`
--- End diff --
Should change this to `_regular-expression_` to match the syntax on line 3367.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/883
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---