[GitHub] [incubator-superset] smacker opened a new pull request #7892: Fix incorrect datasource_name in dashboard export

[GitBox <gi...@apache.org>]

smacker opened a new pull request #7892: Fix incorrect datasource_name in dashboard export
URL: https://github.com/apache/incubator-superset/pull/7892
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   The bug was introduced in #7773
   
   It uses filter by `cls.table_name == datasource_name`:
   https://github.com/apache/incubator-superset/pull/7773/files#diff-a8dd5ec8d8decda2e3c5571d1ec0cdb6R740
   
   But export puts `slc.datasource.name` into exported json:
   https://github.com/apache/incubator-superset/pull/7773/files#diff-ceeb7eee8d573333109e0037299c9711L673
   
   `slc.datasource.name` in case of `SqlaTable` is `"{}.{}".format(self.schema, self.table_name)`
   
   ### TEST PLAN
   
   Export any dashboard using UI, delete it and try to import again.
   
   ### REVIEWERS
   
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org