You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/10 20:09:01 UTC
[jira] [Commented] (AVRO-2075) Allow SchemaCompatibility to report
possibly lossy conversions
[ https://issues.apache.org/jira/browse/AVRO-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160459#comment-16160459 ]
ASF GitHub Bot commented on AVRO-2075:
--------------------------------------
GitHub user epkanol opened a pull request:
https://github.com/apache/avro/pull/246
AVRO-2075: Add option to report possible data loss in SchemaCompatibi…
Same patch as in the JIRA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/epkanol/avro-1 AVRO-2075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #246
----
commit bfaacb70a788a3bcf1639ca592ea64ef2d21dfeb
Author: Anders Sundelin <an...@ericsson.com>
Date: 2017-09-10T17:37:02Z
AVRO-2075: Add option to report possible data loss in SchemaCompatibility
----
> Allow SchemaCompatibility to report possibly lossy conversions
> --------------------------------------------------------------
>
> Key: AVRO-2075
> URL: https://issues.apache.org/jira/browse/AVRO-2075
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.7.7, 1.8.2
> Environment: Java
> Reporter: Anders Sundelin
> Priority: Minor
> Attachments: 0001-AVRO-2075-Add-option-to-report-possible-data-loss-in.patch
>
>
> It is stated in the Avro spec that int and long values are promotable to floats and doubles.
> However, numeric promotions to floats are lossy (losing precision), as is long promotion to double.
> It is suggested that the SchemaCompatibility class is updated to be able to flag conversions that have the possibility to be lossy as errors. The attached patch does just that, by adding a new boolean flag (allowDataLoss), preserving backwards compatibility by defaulting this flag to true.
> Testcases illustrating the problem has been added to the unit test class TestReadingWritingDataInEvolvedSchemas
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)