[jira] [Commented] (OFBIZ-10143) Hardcoded String in PaymentGatewayServices#processCaptureResult

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311198#comment-16311198 ] 

Deepak Dixit commented on OFBIZ-10143:
--------------------------------------

Hi Kyra,

I think we can improve and use ORGANIZATION_PARTY define in general.properties, instead of hard coding "Company", WDYT?

> Hardcoded String in PaymentGatewayServices#processCaptureResult
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Priority: Trivial
>         Attachments: OFBIZ-10143_processCaptureResult_String.patch
>
>
> {code:java}
> // otherwise default to Company and print a big warning about this
> partyIdTo = "Company";
> Debug.logWarning("Using default value of [" + partyIdTo + "] for payTo on invoice [" + invoiceId + "] and orderPaymentPreference ["
> + paymentPreference.getString("orderPaymentPreferenceId") + "]", module);
> {code}
> partyIdTo default value should be final String.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)