[jira] [Commented] (BIGTOP-2057) null check doesn't safeguard against non-existing values in the BOM config

["Evans Ye (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877281#comment-14877281 ] 

Evans Ye commented on BIGTOP-2057:
----------------------------------

Yup. The patch uploaded  10 mins ago looks good to me.
+1. 

> null check doesn't safeguard against non-existing values in the BOM config
> --------------------------------------------------------------------------
>
>                 Key: BIGTOP-2057
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2057
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.1.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>            Priority: Blocker
>             Fix For: 1.1.0
>
>         Attachments: BIGTOP-2057.patch, BIGTOP-2057.patch
>
>
> BIGTOP-2051 has switched the build to use configuration properties instead of java properties. One of the unfortunate side effects of such dynamism is that null checks don't work as expected anymore, as empty elements of the config would be assigned with a ConfigObject instance even after simply null check. That leads to failures for component builds where some elements are omitted all-together, e.g bigtop-utils. 
> Instead of null checks I propose to user {{.isEmpty()}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)