You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2016/03/08 21:48:36 UTC

[Impala-CR](cdh5-trunk) Leopard front end: protect cases where report and schedule paths are absent

Hello Taras Bobrovytsky,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2164

to look at the new patch set (#2).

Change subject: Leopard front end: protect cases where report and schedule paths are absent
......................................................................

Leopard front end: protect cases where report and schedule paths are absent

If the leopard front end is run on a pristine system, the front end will
raise exceptions, because the directories containing reports and
schedules do not yet exist.

Since it's the controller's responsibility to create and populate these
filesystem artifacts, in the frontend, let's just protect against the
exception and log warnings.

Testing:

Before the fix, the reload_reports thread would immediately raise an
exception and the thread would die; loading the Web app in a browser
would cause an internal server error.

After the fix, the reload_reports thread logs a warning but continues to
run, and loading the Web app in a browser presents an appropriately
empty listing of run names and schedules.

Change-Id: I186174db136694d3df04d9159362c6eeaa70b5b8
---
M tests/comparison/leopard/front_end.py
1 file changed, 21 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/2164/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I186174db136694d3df04d9159362c6eeaa70b5b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>