You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2012/11/01 13:01:21 UTC

[Bug 51065] expose socket timeouts in apr_memcache

https://issues.apache.org/bugzilla/show_bug.cgi?id=51065

--- Comment #3 from Joshua Marantz <jm...@google.com> ---
Created attachment 29538
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29538&action=edit
Alternative patch to use the 50ms timeout for all operations without changing
API

I have an alternative solution to the problem identified in this bug.  However
I have a different take on the problem.

The problem is that memcached freezing can freeze Apache using the current
implementation of apr_memcache.c.  The only API that doesn't freeze is
apr_memcache_multgetp because that uses a 50ms poll and will return APR_TIMEUP
if the server exceeds that.

My alternative patch is a drop-in update for the existing apr_memcache.c.  It
differs from the first patch in that it doesn't require an API change; it but
it enforces the 50ms timeout that already exists for apr_multgetp for all
operations.

It works under my load test (which I found is not true of the first patch).
For my own purposes, I will be shipping my module with a copy of apr_memcache.c
with this patch applied, and with all entry-points renamed to 'apr_memcache2*'
so I get the behavior I want regardless of what version of Apache is installed.
 But I'd like to propose my patch for apr_memcache.c.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org