You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/20 08:36:28 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #567: [refactor][discuss] do we need to support int as ID ?
nic-chen opened a new issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567
In APISIX ID could be int or string:
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L28
do we need to support int as ID after refactored?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-713301961
I think we don't need to support int as ID.
String is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-713378859
the string is enough, and just keep one style, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-713520144
OK, I think we got an agreement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-713449515
string +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-714196810
For this question, do we need to do anything else in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-713378859
the string is enough and just keep one style, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #567: [refactor][discuss] do we need to support int as ID ?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567#issuecomment-713300539
cc @membphis @ShiningRush @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org