You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by elilevine <gi...@git.apache.org> on 2014/09/26 08:07:14 UTC
[GitHub] phoenix pull request: Added custom annotations to logs in query-re...
GitHub user elilevine opened a pull request:
https://github.com/apache/phoenix/pull/21
Added custom annotations to logs in query-related functionality in client- and server-side code for PHOENIX-1198
@JamesRTaylor, take a look when you get a chance. Shouldn't be anything controversial. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elilevine/apache-phoenix logging-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit 0aadefe11a9d6e5fb51c89505bcef3b849f99f67
Author: Eli Levine <el...@apache.org>
Date: 2014-09-26T05:22:26Z
Added custom annotations to query-related log lines, both client- and server-side for PHOENIX-1198
commit e34b8c33a067ace5316fd07c8c503f602041e379
Author: Eli Levine <el...@apache.org>
Date: 2014-09-26T05:46:19Z
Added toString() to a bunch of iterators that were missing it to improve logging output for PHOENIX-1198
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Added custom annotations to logs in query-re...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/21#discussion_r18074893
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java ---
@@ -61,6 +61,11 @@
public static final String EXPECTED_UPPER_REGION_KEY = "_ExpectedUpperRegionKey";
public static final String REVERSE_SCAN = "_ReverseScan";
public static final String ANALYZE_TABLE = "_ANALYZETABLE";
+ /**
+ * Attribute name used to pass custom annotations in Scans and Mutations (later). Custom annotations
+ * are used to augment log lines emitted by Phoenix. See https://issues.apache.org/jira/browse/PHOENIX-1198.
+ */
+ public static final String CUSTOM_ANNOTATIONS = "_Annot";
--- End diff --
New attribute for Scans to pass custom annotations to coprocessors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Added custom annotations to logs in query-re...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/21#discussion_r18074918
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java ---
@@ -180,5 +181,12 @@ private boolean rowKeyChanged(Tuple newTuple) {
return Bytes.compareTo(currentKey, offset, length, lastKey.get(), lastKey.getOffset(), lastKey.getLength()) != 0;
}
+
+ @Override
+ public String toString() {
--- End diff --
Added a bunch of toString() methods for objects that might be logged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Added custom annotations to logs in query-re...
Posted by elilevine <gi...@git.apache.org>.
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/21#discussion_r18074909
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -275,7 +276,6 @@ public void remove() {
private long[] validate() throws SQLException {
int i = 0;
Long scn = connection.getSCN();
- PName tenantId = connection.getTenantId();
--- End diff --
Removed unused variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---