You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/08/12 02:15:04 UTC

[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312766046
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
 ##########
 @@ -429,7 +429,9 @@ private void cacheBlockWithWaitInternal(BlockCacheKey cacheKey, Cacheable cached
     if (!cacheEnabled) {
       return;
     }
-    LOG.trace("Caching key={}, item={}", cacheKey, cachedItem);
+    if (LOG.isTraceEnabled()) {
 
 Review comment:
   Correct

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services