You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Paul King (JIRA)" <ji...@apache.org> on 2018/03/06 23:26:11 UTC
[jira] [Closed] (GROOVY-8236) Report more meaningful error for
versions of Groovy not supporting @Repeatable
[ https://issues.apache.org/jira/browse/GROOVY-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul King closed GROOVY-8236.
-----------------------------
> Report more meaningful error for versions of Groovy not supporting @Repeatable
> ------------------------------------------------------------------------------
>
> Key: GROOVY-8236
> URL: https://issues.apache.org/jira/browse/GROOVY-8236
> Project: Groovy
> Issue Type: New Feature
> Environment: groovy 2.4.11
> Reporter: Dmitry Lukyanov
> Assignee: Paul King
> Priority: Major
> Fix For: 2.4.13
>
>
> I cloned the issue. As well as providing support for @Repeatable, we should give a more meaningful error message for any streams of Groovy where we don't support it. I'd guess supported (2.5.0), unsupported (2.4.x); but in any case, this issue is to handle the unsupported case.
> Instead of:
> {noformat}
> java.lang.annotation.AnnotationFormatError ...
> {noformat}
> We could have something like:
> {noformat}
> Annotation @MyAnnotation has RUNTIME retention and 2 occurrences.
> Automatic repeated annotations are not allowed in this version of Groovy.
> Consider explicitly adding the @MyAnnotationArray collector annotation.
> {noformat}
> ---- original description -----
> raised on stackoverflow: https://stackoverflow.com/questions/44532632/is-the-repeatable-annotation-not-supported-by-groovy/44628119#44628119
> Problem: the following code in groovy 2.4.11 / java8
> {code}
> @MyAnnotation(value = "val1")
> @MyAnnotation(value = "val2")
> void annotatedMethod() { println("annotated method called") }
> {code}
> should be compiled to this:
> {code}
> @MyAnnotationArray({@MyAnnotation("val1"), @MyAnnotation("val2")})
> void annotatedMethod() { println("annotated method called") }
> {code}
> but actually compiled to this:
> {code}
> @MyAnnotation(value = "val1")
> @MyAnnotation(value = "val2")
> void annotatedMethod() { println("annotated method called") }
> {code}
> The full groovy script to reproduce problem is below.
> It throws exception:
> {color:red}java.lang.annotation.AnnotationFormatError: Duplicate annotation for class: interface MyAnnotation: @MyAnnotation(value=val2){color}
> at line `List annos = m.getAnnotations()`
> {code}
> import java.lang.annotation.*
> class MyClass
> {
> @MyAnnotation(value = "val1")
> @MyAnnotation(value = "val2")
> //change annotation to next line and the code will work
> //@MyAnnotationArray( [@MyAnnotation("val1"), @MyAnnotation("val2")] )
> public void annotatedMethod()
> {
> System.out.println("annotated method called");
> }
> public static void main(String... args)
> {
> MyClass ob = new MyClass()
> ob.annotatedMethod()
> java.lang.reflect.Method m = ob.getClass().getMethod("annotatedMethod")
> List annos = m.getAnnotations()
> println("annos = $annos")
> }
> }
> @Target(ElementType.METHOD)
> @Retention(RetentionPolicy.RUNTIME)
> @Repeatable(MyAnnotationArray)
> public @interface MyAnnotation
> {
> String value() default "val0";
> }
> @Retention(RetentionPolicy.RUNTIME)
> public @interface MyAnnotationArray
> {
> MyAnnotation[] value()
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)