[GitHub] [airflow] saimon46 commented on a diff in pull request #24846: Bind log server on worker to IPv6 address (#24755)

[GitBox <gi...@apache.org>]

saimon46 commented on code in PR #24846:
URL: https://github.com/apache/airflow/pull/24846#discussion_r958431564


##########
airflow/utils/serve_logs.py:
##########
@@ -138,10 +142,14 @@ def serve_logs():
     wsgi_app = create_app()
 
     worker_log_server_port = conf.getint('logging', 'WORKER_LOG_SERVER_PORT')
-    options = {
-        'bind': f"0.0.0.0:{worker_log_server_port}",
-        'workers': 2,
-    }
+
+    # Make sure to have both an IPv4 and an IPv6 interface.
+    # Gunicorn can bind multiple addresses, see https://docs.gunicorn.org/en/stable/settings.html#bind.
+    options = [
+        GunicornOption("bind", f"0.0.0.0:{worker_log_server_port}"),
+        GunicornOption("bind", f"[::]:{worker_log_server_port}"),

Review Comment:
   Yes, it breaks the gunicorn startup with a failure. Below more details https://github.com/apache/airflow/pull/24846#issuecomment-1231578766



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org