[GitHub] rymanluk commented on a change in pull request #697: BMA2XX Sensor

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #697: BMA2XX Sensor
URL: https://github.com/apache/mynewt-core/pull/697#discussion_r156315118
 
 

 ##########
 File path: hw/drivers/sensors/bma2xx/syscfg.yml
 ##########
 @@ -18,6 +18,48 @@
 #
 
 syscfg.defs:
-    BMA2xx_LOG:
-        description: 'Enable BMA2xx logging'
+    BMA2XX_CLI:
+        description: 'Enable shell support for BMA2XX'
+        value: 0
+    BMA2XX_I2C_WDT:
+        description: 'Enable I2C watchdog functionality'
+        value: 0
+    BMA2XX_INT_ENABLE:
+        description: 'Enable interrupt support, necessary for events'
         value: 1
+    BMA2XX_INT_CFG_ACTIVE:
+        description: 'Set 0 for active-low, 1 for active-high'
+        value: 1
+    BMA2XX_INT_CFG_OUTPUT:
+        description: 'Set 0 for push-pull, 1 for open-drain'
+        value: 1
+    BMA2XX_INT_PIN_DEVICE:
+        description: 'Interrupt pin number 1 or 2 on accelerometer device'
+        value: 1
+    BMA2XX_INT2_PIN_DEVICE:
+        description: 'Interrupt pin number 1 or 2 on accelerometer device'
+        value: 2
+    BMA2XX_INT_PIN_HOST:
+        description: 'Interrupt pin number on host device connected to INT1 on device'
+        value: 20
+    BMA2XX_INT2_PIN_HOST:
+        description: 'Interrupt pin number on host device connected to INT2 on device'
+        value: -1
+    BMA2XX_SPI_CS:
+        description: 'Chip select pin for SPI interface'
+        value: 5
+    BMA2XX_SPI_CLK:
+      description: 'Clock pin for SPI interface'
+      value:
+    BMA2XX_LOG:
+        description: 'Enable BMA2XX logging'
+        value: 0
+    BMA2XX_SHELL_DEV_NAME:
+        description: 'BMA2XX Shell device name'
+        value: "\"bma2xx_0\""
+    BMA280:
 
 Review comment:
   Maybe it could be named BMA2XX_ID and value 1 would be for BMA280, 2 for BMA253 etc. In this way we will not have to produce new flags for each supported sensor but instead add new valid value into description
   
   BTW imho we should not have configuration flags related to host in the driver as it blocks us to have board with more sensors using same driver. This is not what I think should be fix now but rather general idea. I have no good solution for now, but this is something we could think of.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services