[GitHub] [incubator-yunikorn-web] yangwwei commented on a change in pull request #28: YUNIKORN-8: Pull application and container history from core

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #28: YUNIKORN-8: Pull application and container history from core
URL: https://github.com/apache/incubator-yunikorn-web/pull/28#discussion_r400548260
 
 

 ##########
 File path: src/app/components/cluster-info/cluster-info.component.ts
 ##########
 @@ -59,8 +61,13 @@ export class ClusterInfoComponent implements OnInit {
         this.updateContainerStatusData(data);
       });
 
-    this.jobHistoryData = this.generateHistoryData();
-    this.containerHistoryData = this.generateHistoryData();
+    this.scheduler.fetchAppHistory().subscribe(data => {
+      this.jobHistoryData = this.getAreaChartData(data);
 
 Review comment:
   I think we can open a separate JIRA to track that, as that is not blocking the release. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services