You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:01:46 UTC
[GitHub] [james-project] chibenwa opened a new pull request #493: JAMES-3491 Do not send two JMAP events upon new messages
chibenwa opened a new pull request #493:
URL: https://github.com/apache/james-project/pull/493
Before we were firing two events on the JMAP event bus:
- One for emails
- One for mailbox
The following work aggregates both into a single notification
and thus reduces of around 30% RabbitMQ publish rate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #493: JAMES-3491 Do not send two JMAP events upon new messages
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #493:
URL: https://github.com/apache/james-project/pull/493#issuecomment-862033992
Rebased and squashed fixups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #493: JAMES-3491 Do not send two JMAP events upon new messages
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #493:
URL: https://github.com/apache/james-project/pull/493#discussion_r650632850
##########
File path: server/data/data-jmap/src/main/java/org/apache/james/jmap/api/change/MailboxAndEmailChange.java
##########
@@ -0,0 +1,201 @@
+package org.apache.james.jmap.api.change;
Review comment:
Licence missing
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxChangesMethodContract.scala
##########
@@ -889,7 +889,7 @@ trait MailboxChangesMethodContract {
.addHeader(ACCEPT.toString, ACCEPT_RFC8621_VERSION_HEADER)
.setBody(request)
.build, new ResponseSpecBuilder().build)
- .post
+ .post.prettyPeek()
Review comment:
debug spotted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org