You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/10/14 19:58:52 UTC
Review Request 26697: Added StartSlave() overload that takes status
update manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26697/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Added this overload to be able to use for testing status update manager. Used in the subsequent review.
Diffs
-----
src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104
src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773
Diff: https://reviews.apache.org/r/26697/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 26697: Added StartSlave() overload that takes
status update manager.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26697/#review56814
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 15, 2014, 9:26 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26697/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 9:26 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added this overload to be able to use for testing status update manager. Used in the subsequent review.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104
> src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773
>
> Diff: https://reviews.apache.org/r/26697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26697: Added StartSlave() overload that takes
status update manager.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26697/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 9:26 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased. NNFR.
Repository: mesos-git
Description
-------
Added this overload to be able to use for testing status update manager. Used in the subsequent review.
Diffs (updated)
-----
src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104
src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773
Diff: https://reviews.apache.org/r/26697/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 26697: Added StartSlave() overload that takes
status update manager.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26697/#review56593
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Oct. 14, 2014, 10:58 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26697/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 10:58 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added this overload to be able to use for testing status update manager. Used in the subsequent review.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104
> src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773
>
> Diff: https://reviews.apache.org/r/26697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>