[GitHub] [apisix-ingress-controller] fhuzero commented on a change in pull request #598: feat: support for Knative

[GitBox <gi...@apache.org>]

fhuzero commented on a change in pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#discussion_r673893107



##########
File path: tmpvendor/knative.dev/networking/test/test_images/grpc-ping/main.go
##########
@@ -0,0 +1,111 @@
+/*
+Copyright 2019 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package main

Review comment:
       In theory, this directory can be replaced with its online version hosted on GitHub. I've been trying to replace it and reorg Knative-related test directory but encountered some bugs. I'll remove the directory once reorg is done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org