[GitHub] [wicket] solomax commented on pull request #601: Refactor `assertTrue(equals())` using `assertEquals` & `throws Exception` using `assertThrows`

["solomax (via GitHub)" <gi...@apache.org>]

solomax commented on PR #601:
URL: https://github.com/apache/wicket/pull/601#issuecomment-1690925930

   Hello @Taher-Ghaleb 
   
   please revert your commit labeled `[Refactor throws Exception using assertThrows](https://github.com/apache/wicket/pull/601/commits/d667bafbb8081b87fc6dc764f7fc895b066b96d7)`
   
   It breaks the build, because:
   
   If tests is defined as follows:
   ```
   @Test
   	void testExceptionOnMissingResourceDefaultValue() throws Exception
   ```
   
   It doesn't mean it expects the `Exception` to be thrown
   It only states some method **might** throw `Exception` so we should add `try-catch` OR `throws Exception` to satisfy compiler :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org