You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Tim Brooks <tb...@gmail.com> on 2015/07/07 07:00:44 UTC
Review Request 36244: Patch for KAFKA-2312
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36244/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2312
https://issues.apache.org/jira/browse/KAFKA-2312
Repository: kafka
Description
-------
Use an atomic long for the 'light lock' opposed to an atomic reference.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 1f0e51557c4569f0980b72652846b250d00e05d6
Diff: https://reviews.apache.org/r/36244/diff/
Testing
-------
Thanks,
Tim Brooks
Re: Review Request 36244: Patch for KAFKA-2312
Posted by Ismael Juma <mi...@juma.me.uk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36244/#review91514
-----------------------------------------------------------
Ship it!
Ship It!
- Ismael Juma
On July 7, 2015, 5 a.m., Tim Brooks wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36244/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 5 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2312
> https://issues.apache.org/jira/browse/KAFKA-2312
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Use an atomic long for the 'light lock' opposed to an atomic reference.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 1f0e51557c4569f0980b72652846b250d00e05d6
>
> Diff: https://reviews.apache.org/r/36244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tim Brooks
>
>
Re: Review Request 36244: Patch for KAFKA-2312
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36244/#review91519
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On July 7, 2015, 5 a.m., Tim Brooks wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36244/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 5 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2312
> https://issues.apache.org/jira/browse/KAFKA-2312
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Use an atomic long for the 'light lock' opposed to an atomic reference.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 1f0e51557c4569f0980b72652846b250d00e05d6
>
> Diff: https://reviews.apache.org/r/36244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tim Brooks
>
>
Re: Review Request 36244: Patch for KAFKA-2312
Posted by Jason Gustafson <ja...@confluent.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36244/#review91488
-----------------------------------------------------------
Ship it!
LGTM
- Jason Gustafson
On July 7, 2015, 5 a.m., Tim Brooks wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36244/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 5 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2312
> https://issues.apache.org/jira/browse/KAFKA-2312
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Use an atomic long for the 'light lock' opposed to an atomic reference.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 1f0e51557c4569f0980b72652846b250d00e05d6
>
> Diff: https://reviews.apache.org/r/36244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tim Brooks
>
>
Re: Review Request 36244: Patch for KAFKA-2312
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36244/#review90651
-----------------------------------------------------------
Ship it!
Performance-wise, it's a micro-optimization that probably doesn't have any real impact in practical code, but may be a bit more intuitive.
- Ewen Cheslack-Postava
On July 7, 2015, 5 a.m., Tim Brooks wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36244/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 5 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2312
> https://issues.apache.org/jira/browse/KAFKA-2312
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Use an atomic long for the 'light lock' opposed to an atomic reference.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 1f0e51557c4569f0980b72652846b250d00e05d6
>
> Diff: https://reviews.apache.org/r/36244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tim Brooks
>
>