[GitHub] storm issue #2637: Map of Spout configurations from `storm-kafka` to `storm-...

[srdo <gi...@git.apache.org>]

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2637
  
    I read the documentation for maxOffsetBehind you linked, and I think it is confusingly phrased. It says 
    
    > If a failing tuple's offset is less than maxOffsetBehind, the spout stops retrying the tuple
    
    and what they mean is 
    
    > If a failing tuple's offset is farther behind the current offset than maxOffsetBehind (i.e. if `currentOffset - failingOffset > maxOffsetBehind`, the spout stops retrying the tuple
    
    I misread the description as meaning
    
    > If a failing tuple's offset is less than maxOffsetBehind behind the current offset (i.e. if `currentOffset - failingOffset < maxOffsetBehind`), the spout stops retrying the tuple
    
    The links are pointing into the javadocs directory, which is not checked into git. The javadocs directory is supposed to be created when someone publishes release documentation to the site. See the documentation at https://github.com/apache/storm-site#adding-a-new-release-to-the-website for how to generate the javadoc.
    
    I'd expect the links to work if you check out the repo and generate the javadoc.


---