You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by adrian-wang <gi...@git.apache.org> on 2015/10/19 07:54:44 UTC

[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...

Github user adrian-wang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6983#discussion_r42337999
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ---
    @@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
           | FROM src LIMIT 1
         """.stripMargin)
     
    -  createQueryTest("Date comparison test 2",
    -    "SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM src LIMIT 1")
    --- End diff --
    
    @ckadner why do we remove this?
    I think we have handled time zone issue in `beforeAll()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org