You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/08/13 23:24:38 UTC
[jira] [Created] (HBASE-6569) Extract HStore interface from Store
Jesse Yates created HBASE-6569:
----------------------------------
Summary: Extract HStore interface from Store
Key: HBASE-6569
URL: https://issues.apache.org/jira/browse/HBASE-6569
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
Fix For: 0.96.0
Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434669#comment-13434669 ]
Hudson commented on HBASE-6569:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #130 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/130/])
HBASE-6569 Extract HStore interface from Store (Jesse Yates) (Revision 1373153)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileArchiveTestingUtil.java
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435550#comment-13435550 ]
stack commented on HBASE-6569:
------------------------------
The Interface should have been called ColumnFamily? Mind if I change it Jesse?
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434622#comment-13434622 ]
Hudson commented on HBASE-6569:
-------------------------------
Integrated in HBase-TRUNK #3216 (See [https://builds.apache.org/job/HBase-TRUNK/3216/])
HBASE-6569 Extract HStore interface from Store (Jesse Yates) (Revision 1373153)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileArchiveTestingUtil.java
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446798#comment-13446798 ]
Jesse Yates commented on HBASE-6569:
------------------------------------
@stack can we close this issue?
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6569) Extract HStore interface from Store
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6569:
-------------------------------
Attachment: java_HBASE-6569-v0.patch
Attaching patch, posting to RB momentarily. This touches a lot of files, but is 99% just a naming change.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435617#comment-13435617 ]
Zhihong Ted Yu commented on HBASE-6569:
---------------------------------------
+1 on StoreInterface
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434596#comment-13434596 ]
Zhihong Ted Yu commented on HBASE-6569:
---------------------------------------
Test suite has completed.
TestFromClientSideWithCoprocessor#testNonCachedGetRegionLocation failed but passed when run individually.
Integrated to trunk.
Thanks for the patch, Jesse.
Thanks for the review, Andy.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434249#comment-13434249 ]
Andrew Purtell commented on HBASE-6569:
---------------------------------------
+1 after addressing Ted's comments on RB about inconsistent use of 'public' and interface annotations.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6569) Extract HStore interface from Store
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6569:
----------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435601#comment-13435601 ]
stack commented on HBASE-6569:
------------------------------
@Jesse OK. I'm fine w/ keeping logical and implementation distinct -- Store vs ColumnFamily. I'm reacting mostly to the name given the Interface, HStore. If the Interface is to have a letter prefix, can it at least be I for Interface? As ugly as this is, it is better than 'H'. Or StoreInterface?
(Minor point is that Store used to be called HStore. I worked hard to rename it a while ago. I was trying to undo our prefixing everything w/ the redundant 'H'. Thats not important)
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435645#comment-13435645 ]
Jesse Yates commented on HBASE-6569:
------------------------------------
Agree with Ted (and stack). I'm generally against the smurf naming (smurf-berries, smurf-region, smurf-master, etc), but was just trying to keep with convention as it appeared.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6569) Extract HStore interface from Store
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6569:
----------------------------------
Attachment: 6569-v3.patch
Patch from review board.
I am running test suite as well.
Will integrate if there is no objection.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435776#comment-13435776 ]
Lars Hofhansl commented on HBASE-6569:
--------------------------------------
Shouldn't it then be "Store" and "StoreImpl"?
(Note that this falls squarely in the "I couldn't care less" category for me, just saying that's what we used in some other places, maybe we need to generally agree on a convention for HBase).
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6569) Extract HStore interface from Store
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6569:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
The final rename was done in HBASE-6599.
Closing this one.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435565#comment-13435565 ]
Jesse Yates commented on HBASE-6569:
------------------------------------
That's closer, but its still kind of a leaky abstraction if you call it ColumnFamily. Maybe ColumnFamilyManager (something along those lines)?
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434718#comment-13434718 ]
Hadoop QA commented on HBASE-6569:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540950/6569-v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 27 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2571//console
This message is automatically generated.
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6569) Extract HStore interface from Store
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436056#comment-13436056 ]
stack commented on HBASE-6569:
------------------------------
I will make a patch that renames the Interface 'Store' and the implementation 'HStore'. HStore goes with HRegion, etc. Yes, its smurf naming but I think this better than my IStore/StoreInterface and StoreImpl....
> Extract HStore interface from Store
> -----------------------------------
>
> Key: HBASE-6569
> URL: https://issues.apache.org/jira/browse/HBASE-6569
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch
>
>
> Currently Store.java is a top-level class. However, we need to to use the same interface for snapshots (HBASE-6055), and potentially other uses-cases as well, but subclassing is 'dirty' given the amount of state that a Store currently builds up on instantiation.
> For snapshots, we just need to modify the Store actions slightly, making a composition with interface inheritance design very appealing (meaning we need an interface for Store).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira