[jira] Resolved: (WW-992) Fixes broken checkbox and checkboxlist implementation.

["Don Brown (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/struts/browse/WW-992?page=all ]

Don Brown resolved WW-992.
--------------------------

    Fix Version/s: 2.0.0
                       (was: Future)
       Resolution: Fixed
         Assignee: Don Brown  (was: Rene Gielen)

Resolved using a specially named hidden field to detected unchecked checkboxes.  Thanks for the prompting and patch!

> Fixes broken checkbox and checkboxlist implementation.
> ------------------------------------------------------
>
>                 Key: WW-992
>                 URL: http://issues.apache.org/struts/browse/WW-992
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: WW 2.1.7
>         Environment: N/A
>            Reporter: Peter Molettiere
>         Assigned To: Don Brown
>             Fix For: 2.0.0
>
>
> Checkbox handling is broken in webwork, since html checkboxes result in no parameter being sent with the form submission. The parameters interceptor has no way to see the missing checkbox fields, and so never unchecks things with "true" as default, and will not empty a list when a checkboxlist with nothing is selected is submitted.
> This fixes the issue.
> This will make your checkboxes and checkbox lists always set the appropriate values on your model, regardless of whether the checkbox is selected or not. Use the interceptor below in place of the default ParametersInterceptor, and insert this line at the beginning of the checkbox.ftl and checkboxlist.ftl templates:
> <input type="hidden" id="WebWork-checkboxExists" name="${parameters.name?html}" value="${parameters.fieldValue?html}"/>
> Here's the interceptor, written as a subclass of ParametersInterceptor. This could be rolled into ParametersInterceptor.
> import com.opensymphony.xwork.interceptor.ParameterNameAware;
> import com.opensymphony.xwork.interceptor.ParametersInterceptor;
> import com.opensymphony.xwork.util.OgnlValueStack;
> import java.util.Iterator;
> import java.util.Map;
> import java.util.TreeMap;
> public class CheckboxParameterInterceptor extends ParametersInterceptor {
>     protected void setParameters(Object action, OgnlValueStack stack, final Map parameters) {
>         ParameterNameAware parameterNameAware = (action instanceof ParameterNameAware)
>                 ? (ParameterNameAware) action : null;
>         for (Iterator iterator = (new TreeMap(parameters)).entrySet().iterator(); iterator.hasNext();) {
>             Map.Entry entry = (Map.Entry) iterator.next();
>             String name = entry.getKey().toString();
>             boolean acceptableName = acceptableName(name)
>                     && (parameterNameAware == null
>                     || parameterNameAware.acceptableParameterName(name));
>             if (acceptableName) {
>                 Object value = entry.getValue();
>                 if (name.startsWith("WebWork-checkboxExists")) {
>                     String[] checkboxes = (String[]) value;
>                     for (int i = 0; i < checkboxes.length; i++) {
>                         String checkbox = checkboxes[i];
>                         if (! parameters.containsKey(checkbox)) {
>                             stack.setValue(checkbox, new String[0]);
>                         }
>                     }
>                 }
>                 stack.setValue(name, value);
>             }
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira