[GitHub] [maven-scm] michael-o commented on a diff in pull request #150: [SCM-939] Towards JUnit4 ... DRAFT !!

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-scm/pull/150#discussion_r886032110


##########
maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java:
##########
@@ -79,36 +85,33 @@ protected void setUp()
         checkoutMojo.execute();
     }
 
+    @Test
     public void testBranch()
         throws Exception
     {
-        if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
-        {
-            ScmTestCase.printSystemCmdUnavail( SvnScmTestUtils.SVN_COMMAND_LINE, getName() );
-            return;
-        }
+        checkScmPresence( SvnScmTestUtils.SVNADMIN_COMMAND_LINE, "testBranch" );
 
         BranchMojo mojo =
-            (BranchMojo) lookupMojo( "branch", getTestFile( "src/test/resources/mojos/branch/branch.xml" ) );
+            (BranchMojo) lookupMojo( "branch", PlexusJUnit4TestSupport.getTestFile( "src/test/resources/mojos/branch/branch.xml" ) );

Review Comment:
   Why not have the method in the parent class thorugh delegation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org