You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/06 02:06:44 UTC
[PR] test: add first coverage for metrics data source query request [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3973:
URL: https://github.com/apache/rocketmq-dashboard/pull/3973
### Motivation
`MetricsDataSourceQueryRequest` had no unit coverage for its nested query validation or credential redaction. This PR adds first coverage.
### Changes
- A missing query is rejected.
- Nested MetricQueryDTO validation propagates.
- A valid request passes validation.
- toString never exposes the password or bearer token.
### Verification
- `mvn -B test -Dtest=MetricsDataSourceQueryRequestTest`: 4/4 passed, BUILD SUCCESS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: add first coverage for metrics data source query request [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3973: test: add first coverage for metrics data source query request
URL: https://github.com/apache/rocketmq-dashboard/pull/3973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org