[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3244: [INLONG-3243][Sort-Standalone] Support multiple scenes to request configs

[GitBox <gi...@apache.org>]

luchunliang commented on a change in pull request #3244:
URL: https://github.com/apache/incubator-inlong/pull/3244#discussion_r830500966



##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/SortSdkSource.java
##########
@@ -207,7 +220,7 @@ private void updateAllClientConfig() {
      * @param config The config to be updated.
      */
     private void updateClientConfig(SortClientConfig config) {
-        config.setManagerApiUrl(CommonPropertiesHolder.getSourceConfigManagerUrl());
+        config.setManagerApiUrl(ManagerAddrGetHandler.getSortSourceConfigUrl());

Review comment:
       When common.properties have the key "sortSourceConfig.QueryConsumeConfigType", the method "updateClientConfig" is unusable.

##########
File path: inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/config/holder/CommonPropertiesHolder.java
##########
@@ -196,22 +200,22 @@ public static Integer getInteger(String key) {
     public static String getClusterId() {
         return getString(KEY_CLUSTER_ID);
     }
-
+    
     /**
-     * Get manager URL
+     * getAuditFormatInterval
      *
-     * @return Manager URL
+     * @return
      */
-    public static String getSourceConfigManagerUrl() {
-        return getString(KEY_SOURCE_CONFIG_MANAGER_URL);
+    public static long getAuditFormatInterval() {
+        return auditFormatInterval;
     }
 
     /**
-     * getAuditFormatInterval
-     * 
+     * get if managerAddrNeedUpdate
+     *
      * @return
      */
-    public static long getAuditFormatInterval() {
-        return auditFormatInterval;
+    public static boolean isManagerAddrNeedUpdate() {

Review comment:
       The method "isManagerAddrNeedUpdate" is unusable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org