You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/02/10 17:13:48 UTC
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/625
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
A asterix-app/library/externallibtest/testlib/asterix-external-data-0.8.8-SNAPSHOT-tests.jar
A asterix-app/library/externallibtest/testlib/library_descriptor.xml
M asterix-app/pom.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
173 files changed, 1,442,949 insertions(+), 277 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/1
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Murtadha Hubail, Ian Maxon, Till Westmann, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#19).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorDescriptor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
190 files changed, 1,468,592 insertions(+), 635 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/19
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 19:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/866/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#5).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
A asterix-app/library/externallibtest/testlib/asterix-external-data-0.8.8-SNAPSHOT-tests.jar
A asterix-app/library/externallibtest/testlib/library_descriptor.xml
M asterix-app/pom.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
173 files changed, 1,442,984 insertions(+), 276 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#12).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
187 files changed, 1,468,999 insertions(+), 293 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/12
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 15:
(61 comments)
The story around FeedLogManager and AbstractFeedDataFlowController is a little unclear. It seems that those are breaking through too many interfaces and it also does not seem necessary. However, I also do see that changing this would keep us from getting fixes and test coverage earlier and so I think that it is ok to take some technical debt and file an issue for this to be addressed later.
It would be nice if the unused member could be removed and if the licensing for the test files could be addressed.
I didn't look at the implementation of the ClassAd parser.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:
Line 137: public static boolean uninstallLibrary(String dataverse, String libraryName)
We should put the TestLibrarian into the same java package (of course still under src/test/java) so that we can keep this method package local.
Line 189: public static void installLibraryIfNeeded(String dataverse, final File libraryDir,
Could be package local - see above
Line 202: // Another place which shows that our metadata transactions are broken (we didn't call commit before!!!)
Do we need to keep this comment - it's fixed now ...
Line 210: LOGGER.info("Added library " + libraryName + "to Metadata");
space between '"' and 'to'
Line 226: //throw new Exception("No library descriptor defined");
Remove commented code?
Line 295: public static void registerLibrary(String dataverse, String libraryName, boolean isMetadataNode, File installLibDir)
Could be package local - see above
Line 390: public static File getLibraryInstallDir() {
Could be package local - see above
Line 398: public static File getLibraryUninstallDir() {
Could be package local - see above
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java:
Line 34: public class TestLibrarian implements ITestLibrarian {
If we move this to org.apache.asterix.app.external, we can avoid a number of the public interfaces in ExternalLibraryUtils.
Line 60: // install if needed (i,e, add the functions, adapters, datasources, parsers to the metadata) <Not required for use>
line break?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql:
Line 24: ("reader"="adm"),
Why is the reader "adm"? Is that what the parser translates the input to?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql:
Line 1: uninstall externallibtest testlib
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql:
Line 1: uninstall externallibtest testlib
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql:
Line 1: uninstall externallibtest testlib
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql:
Line 1: uninstall externallibtest testlib
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql:
Line 1: uninstall externallibtest testlib
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql:
Line 1: 3000
Can we have a license here?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql:
Line 55:
Why is the index gone?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql:
Line 46: latitude: double,
Could you fix all the whitespace in this file?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql:
Line 46: latitude: double,
Same here, could you fix the whitespace?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:
Line 32: <!-- Fails constantly and not clear what is intended
Could you file issues for the failing tests?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:
Line 149: throw new HyracksDataException("Cannot remove index " + iInfo.datasetId
I guess that the datasetId here actually is an index id. Is that right? Otherwise this error message might be very confusing..
Maybe we can also file an issue, that this (and other) error message should get the user-visible name ...
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:
Line 647: case "lib": // expected format <dataverse-name> <library-name> <library-directory>
I think that we could filter out lines starting with a '#' here to support comments (and licenses) in the test files.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java:
Line 55: private boolean parserFactoryCreated = true;
There's probably a good reason, but I don't see why we need extras flags in here? Couldn't we just check if the factories are null? If we need the flags, could you add a comment?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:
Line 25: import org.apache.asterix.external.util.FeedLogManager;
I'm not sure what a better solution is, but do we agree that this import doesn't seem to fit in here?
Line 74: public void setFeedLogManager(FeedLogManager feedLogManager);;
Same here, also there are 2 semi-colons.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java:
Line 42: this.feedLogManager = feedLogManager;
This is only used/needed in the FeedRecordDataFlowController. Can we keep it there?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 75: LOGGER.warn("Failure during while operating a feed sourcec", th);
s/sourcec/source/
Line 76: throw new HyracksDataException(th);
Why don't we close the forwarder here? Could you add a comment?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java:
Line 34: super(feedLogManager);
Doesn't seem to be needed - but maybe I'm missing something.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:
Line 43: public static final int MAX_RECORD_SIZE = 16000; // temporary until the big object in storage is solved
But isn't that number frame-size-dependent?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java:
Line 164: }
Revert the file?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java:
Line 282: // TODO: fix handling of eod case with monitored buffers.
WS, add an issue?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java:
Line 84: private FeedLogManager feedLogManager;
This seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java:
Line 62: private FeedLogManager feedLogManager;
This seems to be unused ...
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java:
Line 57: private FeedLogManager feedLogManager;
This seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java:
Line 44: protected FeedLogManager feedLogManager;
This seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java:
Line 30: private int recordNumber = 0;
It seems that this is updated, but never read ..
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java:
Line 49: private FeedLogManager feedLogManager;
This seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java:
Line 43: private FeedLogManager feedLogManager;
This seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java:
Line 35: public abstract void setController(AbstractFeedDataFlowController controller);
It is a little confusing why an input stream needs a full data flow controller or a log manager. I think that both are use to pass notifications to and maybe we could think about using a smaller interface here (at some point in the future ..).
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java:
Line 29: private FeedLogManager feedLogManager;
Seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java:
Line 36: private FeedLogManager logManager;
Seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java:
Line 95: TwitterFirehoseInputStreamProvider streamProvider = new TwitterFirehoseInputStreamProvider(configuration, ctx,
If we avoid the variable, we could get it into one line ;)
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java:
Line 37: private FeedLogManager feedLogManager;
Seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java:
Line 32: private Map<String, String> configuration;
Both seem to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java:
Line 53: private FeedLogManager feedLogManager;
Both seem to be unused.
Line 74: private AbstractFeedDataFlowController controller;
Seems to be unused.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
File asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java:
Line 573: "This record is closed, you can not add extra fields !! new field name:" + fldName);
Proposals:
- no space before the exclamation mark
- just one exclamation mark
- a space after the colon
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:
Line 69: Map<String, String> configuration, boolean indexingOp, boolean isFeed, FileSplit[] feedLogFileSplits)
Instead of having the last 3 parameters, couldn't we just pass in some factories as we do for the other things we create in here? That'd be slightly more consistent and we could probably keep the FeedLogManager outside of this method.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java:
Line 76: // If reader is specified, we will use the selected reader. If format is specified, we will assign a suitable reader for the format.
line break?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java:
Line 67: public void endPartition(String partition) throws IOException {
Seems to be unused ...
Line 135: public void logError(String error, Throwable th) throws IOException {
Seems to be unused ...
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java:
Line 96: }
Couldn't this be part of constructing or opening the FeedLogManager?
Seems overly verbose here.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java:
Line 87: this.length--;
Seems that we only need this once?
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java:
Line 167: oldNewOID.put(opDesc.getOperatorId(), metaOp.getOperatorId());
No more inverted indexes?
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 10: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/677/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 19: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/866/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/728/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/837/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 15:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/841/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 4: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/667/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 12: Code-Review+1
(4 comments)
Cool stuff. I didn't look at the ClassAd parser itself though; that sort of stuff is Greek to me :) . We should definitely check in asterix-externaldata/src/test/resources/testdata.txt as binary though. Just a few thoughts other than that.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java:
Line 37: import net.lingala.zip4j.core.ZipFile;
Make sure you add this to NOTICE. It's ASL2 but not from the ASF.
Line 93: public static void removeLibraryDir() throws IOException {
Can there be a sanity check here about what's returned from getLibraryInstallDir()? It would really suck if someone set it to / ;)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:
Line 62: </test-case>
It seems like a lot of these are still broken, maybe we can file an issue about it so we don't lose track?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java:
Line 24:
So maybe this is a stupid question, but why doesn't this situation count as a type of delimited text file?
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 16:
I agree with regards to the FeedDataController and FeedLogManager both in that they need to be revised in that we should do that in a subsequent change :)
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#3).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
A asterix-app/library/externallibtest/testlib/asterix-external-data-0.8.8-SNAPSHOT-tests.jar
A asterix-app/library/externallibtest/testlib/library_descriptor.xml
M asterix-app/pom.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
172 files changed, 1,442,953 insertions(+), 276 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 10:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/677/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 16:
(4 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:
Line 62: // TODO: Find a better way to do flushes, this doesn't fit here
> Could you add a JIRA issue pointing to this interface?
Done
Line 69: // TODO: Find a better way to perform logging. this doesn't fit here
> Could you add a JIRA issue pointing to this interface?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:
Line 66: this.maxRecordSize = ctx.getInitialFrameSize() * 2;
> Shouldn't this be divided by 2?
That is what I did at first. turned out the frame size was configured to be 32kb and ctx.getInitialFrameSize() returned 8kb. I tried to somehow get the actual configured frame size but it was taking a lot of time to do it so I thought this might suffice.
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:
Line 66: // TODO: Instead, use a factory just like data source and data parser.
> Please add a JIRA issue.
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Ian Maxon, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#16).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorDescriptor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
190 files changed, 1,468,601 insertions(+), 646 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/16
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 9: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/676/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 18: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 19: Code-Review+2
Forwarding +2 from Murtadha.
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13:
doing this in a few minutes Till.
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 12:
(34 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:
Line 92: * @return a map from dataverse -> list of uninstalled libraries.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java:
Line 54: if (destinationDir.exists()) {
Replace this if block by
FileUtils.deleteQuietly(destinationDir);
Line 76: public static void rmDirRecursively(String path) throws IOException {
Remove this method.
Line 95: if (installLibDir.exists()) {
Replace this if block by FileUtils.deleteQuietly(installLibDir);
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql:
Line 20: * Description : Create an adapter that uses external parser to parse data from files
Update description
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql:
Line 19:
Just to be consistent, add the test description header.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql:
Line 20: * Description : Create a feed dataset and verify contents in Metadata
Update description and date
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql:
Line 18: */
Add description
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql:
Line 20: * Description : Create a feed dataset and verify contents in Metadata
update description
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql:
Line 19: /*
WSes
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
WSes
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
WSes
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql:
Line 19: /*
WSes
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:
Line 540:
Delete this to avoid PASSED being printed twice in the case of txnqar
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java:
Line 79: public synchronized IDataSourceAdapter createAdapter(IHyracksTaskContext ctx, int partition) throws Exception {
why does this have to be synchronized? who shared the Factory object?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java:
Line 21: public interface IRecordFlowController<T> extends IDataFlowController {
Unless you expect future uses for this interface, just delete it and replace its references by IDataFlowController
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 40: protected AtomicBoolean closed = new AtomicBoolean(false);
final
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java:
Line 98: reader.setFeedLogManager(feedLogManager);
Just a note that if this method is called before setInputStream, then this will throw NPE
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java:
Line 96: public void setFeedLogManager(FeedLogManager logManager) {
Make the super implementation non abstract with unsupportedOp and remove this.
Line 100: public void setController(AbstractFeedDataFlowController controller) {
Make the super implementation non abstract with unsupportedOp and remove this.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java:
Line 111: public void setFeedLogManager(FeedLogManager logManager) {
Make the super implementation non abstract with unsupportedOp and remove this.
Line 115: public void setController(AbstractFeedDataFlowController controller) {
Make the super implementation non abstract with unsupportedOp and remove this.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java:
Line 126: public void setFeedLogManager(FeedLogManager logManager) {
Provide default implementation with unsupportedOp and remove this
Line 130: public void setController(AbstractFeedDataFlowController controller) {
Make the super implementation non abstract with unsupportedOp and remove this.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java:
Line 122: public void setFeedLogManager(FeedLogManager logManager) {
Make the super implementation non abstract with unsupportedOp and remove this.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
File asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java:
Line 87: private FeedLogManager feedLogManager;
Remove this from here.
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#7).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
172 files changed, 1,442,931 insertions(+), 287 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#9).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
176 files changed, 1,443,023 insertions(+), 289 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/9
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Ian Maxon, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#17).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorDescriptor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
190 files changed, 1,468,603 insertions(+), 646 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/17
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/666/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 16:
(4 comments)
Please add the TODOs to JIRA.
There's only one more question on the FeedTupleForwarder.
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:
Line 62: // TODO: Find a better way to do flushes, this doesn't fit here
Could you add a JIRA issue pointing to this interface?
Line 69: // TODO: Find a better way to perform logging. this doesn't fit here
Could you add a JIRA issue pointing to this interface?
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:
Line 66: this.maxRecordSize = ctx.getInitialFrameSize() * 2;
Shouldn't this be divided by 2?
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:
Line 66: // TODO: Instead, use a factory just like data source and data parser.
Please add a JIRA issue.
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 12:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/704/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#8).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
173 files changed, 1,442,933 insertions(+), 289 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/8
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 17: Code-Review+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 5:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/668/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 7: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/674/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/665/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 6:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/673/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 16:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:
Line 66: this.maxRecordSize = ctx.getInitialFrameSize() * 2;
> Shouldn't this be divided by 2?
Now fixed. Got it from the PropertiesProvider
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 12:
(115 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/data/external-parser/dropbox/jobads1.txt
File asterix-app/data/external-parser/dropbox/jobads1.txt:
Line 3: BlockWrites = 0;
> trailing whitespace?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:
Line 92: * @return a map from dataverse -> list of uninstalled libraries.
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java:
Line 37: import net.lingala.zip4j.core.ZipFile;
> Make sure you add this to NOTICE. It's ASL2 but not from the ASF.
Done
Line 54: if (destinationDir.exists()) {
> Replace this if block by
Done
Line 76: public static void rmDirRecursively(String path) throws IOException {
> Remove this method.
Done
Line 93: public static void removeLibraryDir() throws IOException {
> Can there be a sanity check here about what's returned from getLibraryInsta
Mmmm. Shouldn't protecting against that be the responsibility of the OS?
Not sure how to whitelist this but I am giving it a try.
Line 95: if (installLibDir.exists()) {
> Replace this if block by FileUtils.deleteQuietly(installLibDir);
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
> WS
Done
Line 23: finds topics in each tweet. A topic is identified by a #.
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
> WS
Done
Line 23: finds topics in each tweet. A topic is identified by a #.
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
> WS
Done
Line 23: finds topics in each tweet. A topic is identified by a #.
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
> WS
Done
Line 23: finds topics in each tweet. A topic is identified by a #.
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql:
Line 20: * Description : Create an adapter that uses external parser to parse data from files
> Update description
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql:
Line 19:
> Just to be consistent, add the test description header.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql:
Line 20: * Description : Create a feed dataset and verify contents in Metadata
> Update description and date
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql:
Line 18: */
> Add description
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql:
Line 20: * Description : Create a feed dataset and verify contents in Metadata
> update description
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql:
Line 19: /*
> WSes
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
> WSes
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
> WSes
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql:
Line 19: /*
> WSes
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:
Line 62: </test-case>
> It seems like a lot of these are still broken, maybe we can file an issue a
I did not close the already filed issue for feed tests and added a comment to double check those.
most likely, they will go away since there are things that are fundamentally broken with them.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:
Line 540:
> Delete this to avoid PASSED being printed twice in the case of txnqar
Done
Line 601: case "lib": // expected format <dataverse-name> <library-name> <library-directory>
> Space is not a legal character for any of dataverse, library name, library
It is legal. but then taking care of this seems like a lot of effort not well spent since this is strictly test case thing. However, I am adding a todo.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java:
Line 79: public synchronized IDataSourceAdapter createAdapter(IHyracksTaskContext ctx, int partition) throws Exception {
> why does this have to be synchronized? who shared the Factory object?
All task partitions share the factory. This is fine but we shouldn't need this to be synchronized. However, in case of dynamically loaded members, we need to re-create and re-configure them.
because we don't have a way to serialize/deserialize these classes' objects within a hyracks job.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java:
Line 21: public interface IRecordFlowController<T> extends IDataFlowController {
> Unless you expect future uses for this interface, just delete it and replac
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 40: protected AtomicBoolean closed = new AtomicBoolean(false);
> final
Done
Line 74: th.printStackTrace();
> Is this temporary or accidental? Should we have a TODO to remove?
Done
Line 85: th.printStackTrace();
> Is this temporary or accidental? Should we have a TODO to remove?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java:
Line 284: //mBuffer.sendReport(frame);
> Why is this commented out? Is it no longer applicable (i.e. should we just
Still applicable but there is a bug there. I commented it out when I was trying to understand some behavior. re-enabled but added a TODO to fix.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java:
Line 98: reader.setFeedLogManager(feedLogManager);
> Just a note that if this method is called before setInputStream, then this
That happened to me a few times when I was writing this. It should never happen though.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java:
Line 24:
> So maybe this is a stupid question, but why doesn't this situation count as
Not stupid at all. the name is confusing. with delimited text, each two records are separated by a new line.
With this one, each two records are separated by an empty line. I am using it for the old condor format where each line has an attribute and an empty line means end of record.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java:
Line 96: public void setFeedLogManager(FeedLogManager logManager) {
> Make the super implementation non abstract with unsupportedOp and remove th
Mmmm, I have made some changes and each feed/feed_inputstream will get assigned a log manager. whether they decide to make use of it or not is up to the implementation.
Line 100: public void setController(AbstractFeedDataFlowController controller) {
> Make the super implementation non abstract with unsupportedOp and remove th
Mmmm, I have made some changes and each feed/feed_inputstream will get assigned a reference to the data flow controller. whether they decide to make use of it or not is up to the implementation.
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java:
Line 111: public void setFeedLogManager(FeedLogManager logManager) {
> Make the super implementation non abstract with unsupportedOp and remove th
Done
Line 115: public void setController(AbstractFeedDataFlowController controller) {
> Make the super implementation non abstract with unsupportedOp and remove th
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java:
Line 126: public void setFeedLogManager(FeedLogManager logManager) {
> Provide default implementation with unsupportedOp and remove this
Done
Line 130: public void setController(AbstractFeedDataFlowController controller) {
> Make the super implementation non abstract with unsupportedOp and remove th
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java:
Line 122: public void setFeedLogManager(FeedLogManager logManager) {
> Make the super implementation non abstract with unsupportedOp and remove th
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
File asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java:
Line 87: private FeedLogManager feedLogManager;
> Remove this from here.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:
Line 63: * @param feedLogFileSplits
> trailing whitespace (and next line)
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java:
Line 77: "Unspecified (\"reader\" or \"format\") parameter for local file system adapter");
> Prefer "filesystem" myself, but I guess both are acceptable.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java:
Line 142: recordLogger.newLine();
> Each call to recordLogger is pretty heavy, includes synchronization, using
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java:
Line 130: System.arraycopy(otherString.toCharArray(), 0, value, 0, length);
> Should use String.getChars() to avoid the temporary char [] allocation (toC
Done
Line 336: System.arraycopy(aString.toCharArray(), 0, value, i, aString.length());
> Should use String.getChars() to avoid the temporary char [] allocation (toC
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java:
Line 78: *
> trailing ws
Done
Line 90: *
> trailing ws
Done
Line 113: *
> trailing ws
Done
Line 132: // Will this check result in infinite recursion? How do I stop it?
> trailing ws
Done
Line 234: // lookup with scope; this may side-affect state
> trailing ws
Done
Line 402: *
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java:
Line 58: if (name.equalsIgnoreCase("isundefined")) {
> equalsIgnoreCase is not very efficient when used over and over I think- rep
Done
Line 109: // undefined and we're supposed to test for strict comparison, the
> trailing ws
Done
Line 234: // Either take the number if it's the first,
> trailing ws
Done
Line 305: // For this element of the list, make sure it is
> trailing ws
Done
Line 363: } else if (!stringValue.isStringValue(comparison_string)) {
> This seems easy to miss that this "is" test method has the side-effect of c
I totally agree with you but I'd rather keep it like this if we ever hope our customers take ownership since they use this naming convention.
Line 369: if (comparison_string.equalsString("<")) {
> Seems a good candidate for a string-switch.
Done
Line 422: // For this element of the list, make sure it is
> trailing ws
Done
Line 581: format = format.replaceAll("%m", "MM");
> You don't want replaceAll here, that is denoting a regex, I think you're tr
Done
Line 620: if (name.equalsIgnoreCase("getyear")) {
> Same comment as above, I would favor string switch on case-normalized name
Done
Line 646: if (name.equalsIgnoreCase("getyear") || name.equalsIgnoreCase("getmonth")
> Same comment as above, I would favor string switch on case-normalized name
Done
Line 878: // only one argument
> trailing ws
Done
Line 1192: // use the printpretty on arg0 to spew out
> trailing ws
Done
Line 1288: // absTime with no arguments returns the current time.
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java:
Line 47: return 0;
> Shouldn't we implement this, comparing the normalized (lower case) value?
huh!!
they didn't have a test case for it.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java:
Line 466: // only try to process if the string is valid
> trailing ws
Done
Line 499: // if caching is enabled, and we got to here then we know that the
> trailing ws
Done
Line 617: return EvalResult.EVAL_FAIL.ordinal(); // NAC
> trailing ws
Done
Line 639: // --- begin deletion methods
> trailing ws
Done
Line 717: // already set by base class for this node; we shouldn't propagate
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java:
Line 53: *
> trailing ws
Done
Line 133: // digits as possible, which is why we don't use the
> trailing ws
Done
Line 199: *
> trailing ws
Done
Line 473: * based on the character content,
> trailing ws
Done
Line 474: * it's unparsed either as a quoted attribute or non-quoted attribute
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java:
Line 38: /// Attribute reference node (attr, .attr, expr.attr)
> trailing ws
Done
Line 42: /// Function call node
> trailing ws
Done
Line 44: /// ClassAd node
> trailing ws
Done
Line 46: /// Expression list node
> trailing ws
Done
Line 130: *
> trailing ws
Done
Line 139: *
> trailing ws
Done
Line 148: *
> trailing ws
Done
Line 301: *
> trailing ws
Done
Line 320: *
> trailing ws
Done
Line 327: *
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java:
Line 108: // pattern matching (regular expressions)
> trailing ws
Done
Line 120: // turn the contents of an expression into a string
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java:
Line 77: System.arraycopy(buffer, 0, buffer, 1, buffer.length - 1);
> Doesn't this instead duplicate the next character instead of reinstating th
Not sure how this slipped. But then again, it has been a few months since I last looked at this. Not sure if I broke it nowDone
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java:
Line 580: // tokenizeStringLiteral: Scans strings of the form " ... " or '...'
> trailing ws
Done
Line 642: // tokenizePunctOperator: Tokenize puncutation and operators
> trailing ws
Done
Line 840: // cut the token and return
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java:
Line 31: * LexerSource that provide access to specific types of sources.
> trailing ws
Done
Line 53: // ever put back a single character.
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java:
Line 115: /* Creates an absolute time literal, from the string timestr,
> trailing ws
Done
Line 215: /* Creates a relative time literal, from the string timestr,
> trailing ws
Done
Line 319: /* Function which iterates through the string Str from the location 'index',
> trailing ws
Done
Line 320: *returning the index of the next digit-char
> trailing ws
Done
Line 366: * which is the number of seconds since the epoch
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java:
Line 41: /// List of supported operators
> trailing ws
Done
Line 110: *
> trailing ws
Done
Line 133: *
> trailing ws
Done
Line 147: *
> trailing ws
Done
Line 163: *
> trailing ws
Done
Line 674: // if op is binary, but not associative or commutative, disallow splitting
> trailing ws
Done
Line 927: // comparison between strings and non-exceptional non-string
> trailing ws
Done
Line 1218: // trap sigfpe and set the ClassAdExprFPE flag to true; on NT check the
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java:
Line 74: char digit = text.charAt(source + 1); // is the next digit also
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java:
Line 85: public boolean isBooleanValue(MutableBoolean b) {
> Same comment as earlier- personally I would prefer some method naming that
I too prefer that but I prefer to stick to the users' conventions in hope of moving ownership one day :)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java:
Line 27: return new AMutableCharArrayString(32);
> Why 32 for pool instances?
arbitrary choice that made some sense. like it is not too small so we will re-allocate and not so large so we end up consuming too much memory
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java:
Line 51: *
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java:
Line 60: *
> trailing ws
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java:
Line 85: // Then we parse to see what the user wants.
> trailing ws
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 16:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/860/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Ian Maxon, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#14).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
191 files changed, 1,468,514 insertions(+), 510 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/14
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13:
(50 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/13/.gitattributes
File .gitattributes:
Line 19: # Exeplicitly declare binary files
> Explicitly (sp.)
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 75: th.printStackTrace();
> printStackTrace() still here, I assume you meant to replace this with the L
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java:
Line 90: if (feedLogManager.exists()) {
> if(!feedLogManager.exists(){
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java:
Line 37: value = new char[64];
> replace 64 by increment
Done
Line 235: public int fistNonDigitChar() {
was intentional :p
Done.
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java:
Line 97: boolean success = true;
> success value is never changed. In case of failure, an exception will be th
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java:
Line 50: return true;
> what does it mean to return true here?
I am not sure but this is matches the c++ implementation of the classad functions.
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java:
Line 109: return null;
> return buffer?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java:
Line 41: /// List of supported operators
> WS
Done
Line 110: *
> WS
Done
Line 133: *
> WS
Done
Line 147: *
> WS
Done
Line 163: *
> WS
Done
Line 674: // if op is binary, but not associative or commutative, disallow splitting
> WS
Done
Line 826: // same operators on both children . since op!=NO_OP, neither are op1,
> WS
Done
Line 927: // comparison between strings and non-exceptional non-string
> WS
Done
Line 1218: // trap sigfpe and set the ClassAdExprFPE flag to true; on NT check the
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java:
Line 135: *
> WS
Done
Line 145: // Then we parse to see what the user wants.
> WS
Done
Line 219: *
> WS
Done
Line 236: *
> WS
Done
Line 261: *
> WS
Done
Line 274: // We don't increment it until we use it.
> WS
Done
Line 327: *
> WS
Done
Line 371: // We have to be careful with substr() because with gcc 2.96, it likes to
> WS
Done
Line 457: *
> WS
Done
Line 520: *
> WS
Done
Line 544: *
> WS
Done
Line 573: *
> WS
Done
Line 587: *
> WS
Done
Line 630: *
> WS
Done
Line 649: *
> WS
Done
Line 675: *
> WS
Done
Line 756: *
> WS
Done
Line 764:
> WS
Done
Line 791:
> WS
Done
Line 795: *
> WS
Done
Line 803:
> WS
Done
Line 811:
> WS
Done
Line 827:
> WS
Done
Line 984: *
> WS
Done
Line 1007: *
> WS
Done
Line 1056: *
> WS
Done
Line 1083: *
> WS
Done
Line 1100: // We have to be careful with substr() because with gcc 2.96, it likes to
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:
Line 139: *
> WS
Done
Line 658: *
> WS
Done
Line 727: *
> WS
Done
Line 794: *
> WS
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
File asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql:
Line 18: */
> This file is not needed
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#11).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
186 files changed, 1,456,130 insertions(+), 293 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/11
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 11:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/678/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 18: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/864/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 2: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/665/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Ian Maxon, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#15).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off some time ago due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
191 files changed, 1,468,514 insertions(+), 510 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/15
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Blow has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/13/.gitattributes
File .gitattributes:
Line 19: # Exeplicitly declare binary files
Explicitly (sp.)
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 75: th.printStackTrace();
printStackTrace() still here, I assume you meant to replace this with the LOGGER.warn...
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 15: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/841/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/728/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 7:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/674/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 14: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/734/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/809/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 16: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/860/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Ian Maxon, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#13).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
187 files changed, 1,468,460 insertions(+), 482 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/13
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Blow has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 12:
(77 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/data/external-parser/dropbox/jobads1.txt
File asterix-app/data/external-parser/dropbox/jobads1.txt:
Line 3: BlockWrites = 0;
trailing whitespace?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:
Line 601: case "lib": // expected format <dataverse-name> <library-name> <library-directory>
Space is not a legal character for any of dataverse, library name, library directory?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 74: th.printStackTrace();
Is this temporary or accidental? Should we have a TODO to remove?
Line 85: th.printStackTrace();
Is this temporary or accidental? Should we have a TODO to remove?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java:
Line 284: //mBuffer.sendReport(frame);
Why is this commented out? Is it no longer applicable (i.e. should we just remove it?)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:
Line 63: * @param feedLogFileSplits
trailing whitespace (and next line)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java:
Line 77: "Unspecified (\"reader\" or \"format\") parameter for local file system adapter");
Prefer "filesystem" myself, but I guess both are acceptable.
Do exactly one of these need to be specified? Should this error message be clarified to indicate what is expected?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java:
Line 142: recordLogger.newLine();
Each call to recordLogger is pretty heavy, includes synchronization, using StringBuilder and calling a single recordLogger.write(buf.toString()) would be preferred...
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java:
Line 130: System.arraycopy(otherString.toCharArray(), 0, value, 0, length);
Should use String.getChars() to avoid the temporary char [] allocation (toCharArray())
Line 336: System.arraycopy(aString.toCharArray(), 0, value, i, aString.length());
Should use String.getChars() to avoid the temporary char [] allocation (toCharArray())
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java:
Line 78: *
trailing ws
Line 90: *
trailing ws
Line 113: *
trailing ws
Line 132: // Will this check result in infinite recursion? How do I stop it?
trailing ws
Line 234: // lookup with scope; this may side-affect state
trailing ws
Line 402: *
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java:
Line 58: if (name.equalsIgnoreCase("isundefined")) {
equalsIgnoreCase is not very efficient when used over and over I think- replacing this with a switch on name.toLowerCase() would probably be better.
Line 109: // undefined and we're supposed to test for strict comparison, the
trailing ws
Line 234: // Either take the number if it's the first,
trailing ws
Line 305: // For this element of the list, make sure it is
trailing ws
Line 363: } else if (!stringValue.isStringValue(comparison_string)) {
This seems easy to miss that this "is" test method has the side-effect of copying the string value into comparison_string. Perhaps we could change this to setIfStringValue() or something? Dunno.
Line 369: if (comparison_string.equalsString("<")) {
Seems a good candidate for a string-switch.
Line 422: // For this element of the list, make sure it is
trailing ws
Line 581: format = format.replaceAll("%m", "MM");
You don't want replaceAll here, that is denoting a regex, I think you're trying to do 1:1 replacement, which would be best serviced by String.replace().
Line 620: if (name.equalsIgnoreCase("getyear")) {
Same comment as above, I would favor string switch on case-normalized name
Line 646: if (name.equalsIgnoreCase("getyear") || name.equalsIgnoreCase("getmonth")
Same comment as above, I would favor string switch on case-normalized name
Line 878: // only one argument
trailing ws
Line 1192: // use the printpretty on arg0 to spew out
trailing ws
Line 1288: // absTime with no arguments returns the current time.
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java:
Line 47: return 0;
Shouldn't we implement this, comparing the normalized (lower case) value?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java:
Line 466: // only try to process if the string is valid
trailing ws
Line 499: // if caching is enabled, and we got to here then we know that the
trailing ws
Line 617: return EvalResult.EVAL_FAIL.ordinal(); // NAC
trailing ws
Line 639: // --- begin deletion methods
trailing ws
Line 717: // already set by base class for this node; we shouldn't propagate
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java:
Line 53: *
trailing ws
Line 133: // digits as possible, which is why we don't use the
trailing ws
Line 199: *
trailing ws
Line 473: * based on the character content,
trailing ws
Line 474: * it's unparsed either as a quoted attribute or non-quoted attribute
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java:
Line 38: /// Attribute reference node (attr, .attr, expr.attr)
trailing ws
Line 42: /// Function call node
trailing ws
Line 44: /// ClassAd node
trailing ws
Line 46: /// Expression list node
trailing ws
Line 130: *
trailing ws
Line 139: *
trailing ws
Line 148: *
trailing ws
Line 301: *
trailing ws
Line 320: *
trailing ws
Line 327: *
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java:
Line 108: // pattern matching (regular expressions)
trailing ws
Line 120: // turn the contents of an expression into a string
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java:
Line 77: System.arraycopy(buffer, 0, buffer, 1, buffer.length - 1);
Doesn't this instead duplicate the next character instead of reinstating the last one?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java:
Line 580: // tokenizeStringLiteral: Scans strings of the form " ... " or '...'
trailing ws
Line 642: // tokenizePunctOperator: Tokenize puncutation and operators
trailing ws
Line 840: // cut the token and return
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java:
Line 31: * LexerSource that provide access to specific types of sources.
trailing ws
Line 53: // ever put back a single character.
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java:
Line 115: /* Creates an absolute time literal, from the string timestr,
trailing ws
Line 215: /* Creates a relative time literal, from the string timestr,
trailing ws
Line 319: /* Function which iterates through the string Str from the location 'index',
trailing ws
Line 320: *returning the index of the next digit-char
trailing ws
Line 366: * which is the number of seconds since the epoch
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java:
Line 41: /// List of supported operators
trailing ws
Line 110: *
trailing ws
Line 133: *
trailing ws
Line 147: *
trailing ws
Line 163: *
trailing ws
Line 674: // if op is binary, but not associative or commutative, disallow splitting
trailing ws
Line 927: // comparison between strings and non-exceptional non-string
trailing ws
Line 1218: // trap sigfpe and set the ClassAdExprFPE flag to true; on NT check the
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java:
Line 74: char digit = text.charAt(source + 1); // is the next digit also
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java:
Line 85: public boolean isBooleanValue(MutableBoolean b) {
Same comment as earlier- personally I would prefer some method naming that would indicate there is a side-effect of the 'is' check (i.e. setting the value of the passed boolean holder)
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java:
Line 27: return new AMutableCharArrayString(32);
Why 32 for pool instances?
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java:
Line 51: *
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java:
Line 60: *
trailing ws
https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java:
Line 85: // Then we parse to see what the user wants.
trailing ws
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 1: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/809/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 14:
Now show me that +2 :p
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/838/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 4:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/667/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 18:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/864/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13: -Verified
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/837/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has submitted this change and it was merged.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/625
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <ba...@gmail.com>
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorDescriptor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
190 files changed, 1,468,592 insertions(+), 635 deletions(-)
Approvals:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 12: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/704/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 11:
(40 comments)
Did first round of reviews (up to IRecordReader).
I also had to rebase this change to master in order to be able to build it.
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:
Line 82: // install if needed (i,e, add the functions, adapters, datasources, parsers to the metadata) <Not required for use>
fix linebreak
Line 92: * @return a map from dataverse -> list of uninstalled libraries.
WS
Line 127: * TODO Currently, external libraries only include functions and adapters. we need to extend this to include:
Could you file a JIRA for this?
Line 143: // make sure dataverse exists
Do we need this check? Won't this happen automatically when checking for the library?
Line 210: LOGGER.info("Added library " + libraryName + "to Metadata");
add space between quote and "to"
Line 226: //throw new Exception("No library descriptor defined");
remove commented code?
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java:
Line 51: source.getName();
Why do we call this?
Line 60: } catch (Exception e) {
Would be enough to catch ZipException here?
Line 62: throw new Exception("Couldn't unzip the file: " + source, e);
remove empty line above?
Line 67: // install if needed (i,e, add the functions, adapters, datasources, parsers to the metadata) <Not required for use>
fix line break?
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql:
Line 22: Associate with the feed an external user-defined function. The UDF
WS
Line 23: finds topics in each tweet. A topic is identified by a #.
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql:
Line 1: 3000
We should not remove the header if the file ends in .aql ...
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
WS
Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed.
WS
Line 23: The feed lasts a configured duration with data arriving at a configured rate (tweets per second).
WS
Line 25: * Issue : 711
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
WS
Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed.
WS
Line 23: The feed lasts a configured duration with data arriving at a configured rate (tweets per second).
WS
Line 25: * Issue : 711
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
WS
Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed.
WS
Line 23: The feed lasts a configured duration with data arriving at a configured rate (tweets per second).
WS
Line 25: * Issue : 711
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql:
Line 20: * Description : Create a feed using the synthetic feed simulator adapter.
WS
Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed.
WS
Line 23: The feed lasts a configured duration with data arriving at a configured rate (tweets per second).
WS
Line 25: * Issue : 711
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:
Line 103: <!--
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java:
Line 86: private void restoreExternalObjects() throws Exception {
Why is this methods called "restore..."? It seems that it's initializing stuff.
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java:
Line 31: public void setFeedLogManager(FeedLogManager feedLogManager);
Why do we have these methods here? Couldn't we pass the configuration in when we create the IInputStreamProvider instance?
(Also, I'm not sure why every InputStream would get a "FeedLogManager".)
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java:
Line 21: public interface IRecordFlowController<T> extends IDataFlowController {
Remove the whole interface?
https://asterix-gerrit.ics.uci.edu/#/c/625/11/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:
Line 74: public void setFeedLogManager(FeedLogManager feedLogManager);;
Why would every RecordReader get a FeedLogManager? Is this really Feeds-specific?
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 15:
It would be really nice to get this in since many fixes are here and in order to address other bugs that are assigned to me.
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 9:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/676/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Ian Maxon, Till Westmann, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#18).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
M .gitattributes
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/dropbox/jobads2.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
C asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
C asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorDescriptor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
R asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
C asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
C asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
190 files changed, 1,468,603 insertions(+), 646 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/18
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 3: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/666/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 11: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/678/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#10).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/dropbox/jobads1.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
M asterix-app/pom.xml
M asterix-app/src/main/assembly/binary-assembly.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.7.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.4.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
A asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser/feed-with-external-parser.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
187 files changed, 1,456,131 insertions(+), 294 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/10
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 6: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/673/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13: -Verified
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/838/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 17:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/863/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 8:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/675/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 17: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/863/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#2).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. We are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
A asterix-app/library/externallibtest/testlib/asterix-external-data-0.8.8-SNAPSHOT-tests.jar
A asterix-app/library/externallibtest/testlib/library_descriptor.xml
M asterix-app/pom.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
173 files changed, 1,442,949 insertions(+), 277 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 5: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/668/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 15:
(61 comments)
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:
Line 137: public static boolean uninstallLibrary(String dataverse, String libraryName)
> We should put the TestLibrarian into the same java package (of course still
Done
Line 189: public static void installLibraryIfNeeded(String dataverse, final File libraryDir,
> Could be package local - see above
Done
Line 202: // Another place which shows that our metadata transactions are broken (we didn't call commit before!!!)
> Do we need to keep this comment - it's fixed now ...
I'd rather leave it since I believe metadata transaction are still broken since this used to work.
Just another reminder to take a look at metadata transactions.
Line 210: LOGGER.info("Added library " + libraryName + "to Metadata");
> space between '"' and 'to'
Done
Line 226: //throw new Exception("No library descriptor defined");
> Remove commented code?
Done
Line 295: public static void registerLibrary(String dataverse, String libraryName, boolean isMetadataNode, File installLibDir)
> Could be package local - see above
Done
Line 390: public static File getLibraryInstallDir() {
> Could be package local - see above
Done
Line 398: public static File getLibraryUninstallDir() {
> Could be package local - see above
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java:
Line 34: public class TestLibrarian implements ITestLibrarian {
> If we move this to org.apache.asterix.app.external, we can avoid a number o
Done
Line 60: // install if needed (i,e, add the functions, adapters, datasources, parsers to the metadata) <Not required for use>
> line break?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql:
Line 24: ("reader"="adm"),
> Why is the reader "adm"? Is that what the parser translates the input to?
this means that the input is semi-structured. we can use reader=semi-structured as well.
I have changed it
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql:
Line 1: uninstall externallibtest testlib
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql:
Line 1: uninstall externallibtest testlib
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql:
Line 1: uninstall externallibtest testlib
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
File asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql:
Line 1: uninstall externallibtest testlib
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.2.lib.aql:
Line 1: install externallibtest testlib src/test/resources/externallib/testlib-zip-binary-assembly.zip
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser/feed-with-external-parser.6.lib.aql:
Line 1: uninstall externallibtest testlib
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql:
Line 1: 3000
> Can we have a license here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql:
Line 55:
> Why is the index gone?
because the field doesn't exists and so it will simply fail.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql:
Line 46: latitude: double,
> Could you fix all the whitespace in this file?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql:
Line 46: latitude: double,
> Same here, could you fix the whitespace?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:
Line 32: <!-- Fails constantly and not clear what is intended
> Could you file issues for the failing tests?
There is already an issue that has a comment about them.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:
Line 149: throw new HyracksDataException("Cannot remove index " + iInfo.datasetId
> I guess that the datasetId here actually is an index id. Is that right? Oth
Actually, this one should be reverted. I added it while debugging something :)
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:
Line 647: case "lib": // expected format <dataverse-name> <library-name> <library-directory>
> I think that we could filter out lines starting with a '#' here to support
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java:
Line 55: private boolean parserFactoryCreated = true;
> There's probably a good reason, but I don't see why we need extras flags in
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:
Line 25: import org.apache.asterix.external.util.FeedLogManager;
> I'm not sure what a better solution is, but do we agree that this import do
Added a todo to find a better way to do this.
Line 74: public void setFeedLogManager(FeedLogManager feedLogManager);;
> Same here, also there are 2 semi-colons.
Added a todo to find better place for flushing frames and perform logging
Done.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java:
Line 42: this.feedLogManager = feedLogManager;
> This is only used/needed in the FeedRecordDataFlowController. Can we keep i
Both FeedRecordDataFlowController and FeedStreamRecordDataFlowController should use it. the thing is that all currently "tested" feeds use FeedRecordDataFlowController and so it was only used there.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:
Line 75: LOGGER.warn("Failure during while operating a feed sourcec", th);
> s/sourcec/source/
Done
Line 76: throw new HyracksDataException(th);
> Why don't we close the forwarder here? Could you add a comment?
The reason is that if the throwable was caused by a bad record, we will come back to this loop and we want the forwarder to be closed later. Now that you mentioned it, If the adapter doesn't handle the exception, it will never be closed. I have fixed this.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java:
Line 34: super(feedLogManager);
> Doesn't seem to be needed - but maybe I'm missing something.
It should be needed. Unfortunately, we don't have yet feed tests that use stream parsers!.
I will keep it for now but probably this whole class will go away.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:
Line 43: public static final int MAX_RECORD_SIZE = 16000; // temporary until the big object in storage is solved
> But isn't that number frame-size-dependent?
yes but this was a quick way to handle the big record case. I have fixed it now.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameSpiller.java:
Line 164: }
> Revert the file?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java:
Line 282: // TODO: fix handling of eod case with monitored buffers.
> WS, add an issue?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java:
Line 84: private FeedLogManager feedLogManager;
> This seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java:
Line 62: private FeedLogManager feedLogManager;
> This seems to be unused ...
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java:
Line 57: private FeedLogManager feedLogManager;
> This seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java:
Line 44: protected FeedLogManager feedLogManager;
> This seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java:
Line 30: private int recordNumber = 0;
> It seems that this is updated, but never read ..
That is right. It was created for progress tracking which is still not yet completed.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java:
Line 49: private FeedLogManager feedLogManager;
> This seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java:
Line 43: private FeedLogManager feedLogManager;
> This seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java:
Line 35: public abstract void setController(AbstractFeedDataFlowController controller);
> It is a little confusing why an input stream needs a full data flow control
I agree and I am not happy with it either. but it works for now :)
Added a todo
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java:
Line 29: private FeedLogManager feedLogManager;
> Seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java:
Line 36: private FeedLogManager logManager;
> Seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java:
Line 95: TwitterFirehoseInputStreamProvider streamProvider = new TwitterFirehoseInputStreamProvider(configuration, ctx,
> If we avoid the variable, we could get it into one line ;)
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java:
Line 37: private FeedLogManager feedLogManager;
> Seems to be unused.
It is used. we pass it to the input stream which in turns passes it to the file system watcher :)
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java:
Line 32: private Map<String, String> configuration;
> Both seem to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java:
Line 53: private FeedLogManager feedLogManager;
> Both seem to be unused.
Done
Line 74: private AbstractFeedDataFlowController controller;
> Seems to be unused.
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
File asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java:
Line 573: "This record is closed, you can not add extra fields !! new field name:" + fldName);
> Proposals:
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:
Line 69: Map<String, String> configuration, boolean indexingOp, boolean isFeed, FileSplit[] feedLogFileSplits)
> Instead of having the last 3 parameters, couldn't we just pass in some fact
I think that would work but it will be a larger change. hence, I will add a TODO instead.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java:
Line 76: // If reader is specified, we will use the selected reader. If format is specified, we will assign a suitable reader for the format.
> line break?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java:
Line 67: public void endPartition(String partition) throws IOException {
> Seems to be unused ...
Right but I would really like to keep it until I am done with the at least once policy.
I have a plan to use it later.
Line 135: public void logError(String error, Throwable th) throws IOException {
> Seems to be unused ...
Right but I would really like to keep it until I am done with the at least once policy.
I have a plan to use it later.
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java:
Line 96: }
> Couldn't this be part of constructing or opening the FeedLogManager?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java:
Line 87: this.length--;
> Seems that we only need this once?
Done
https://asterix-gerrit.ics.uci.edu/#/c/625/15/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java:
Line 167: oldNewOID.put(opDesc.getOperatorId(), metaOp.getOperatorId());
> No more inverted indexes?
I don't think that wrapping "non-primary" insert delete operators with feed store operator is a good idea and so, I have changed this to only wrap the first operator (the primary index insert delete operator)
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 14:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/734/
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#6).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
A asterix-app/library/externallibtest/testlib/asterix-external-data-0.8.8-SNAPSHOT-tests.jar
A asterix-app/library/externallibtest/testlib/library_descriptor.xml
M asterix-app/pom.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
173 files changed, 1,443,015 insertions(+), 287 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13:
It would be really nice if this change would build against hyracks master - not sure how to try it out right now.
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 13:
(48 comments)
The rest of my comments. Nothing major. There is some C++ code style, but it can be cleaned in a different change.
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java:
Line 90: if (feedLogManager.exists()) {
if(!feedLogManager.exists(){
feedLogManager.create();
}
feedLogManager.open();
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java:
Line 37: value = new char[64];
replace 64 by increment
Line 235: public int fistNonDigitChar() {
first
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java:
Line 97: boolean success = true;
success value is never changed. In case of failure, an exception will be thrown. If this isn't the required behavior, then catch the exception and return false.
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java:
Line 50: return true;
what does it mean to return true here?
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java:
Line 109: return null;
return buffer?
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java:
Line 41: /// List of supported operators
WS
Line 110: *
WS
Line 133: *
WS
Line 147: *
WS
Line 163: *
WS
Line 674: // if op is binary, but not associative or commutative, disallow splitting
WS
Line 826: // same operators on both children . since op!=NO_OP, neither are op1,
WS
Line 927: // comparison between strings and non-exceptional non-string
WS
Line 1218: // trap sigfpe and set the ClassAdExprFPE flag to true; on NT check the
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java:
Line 135: *
WS
Line 145: // Then we parse to see what the user wants.
WS
Line 219: *
WS
Line 236: *
WS
Line 261: *
WS
Line 274: // We don't increment it until we use it.
WS
Line 327: *
WS
Line 371: // We have to be careful with substr() because with gcc 2.96, it likes to
WS
Line 457: *
WS
Line 520: *
WS
Line 544: *
WS
Line 573: *
WS
Line 587: *
WS
Line 630: *
WS
Line 649: *
WS
Line 675: *
WS
Line 756: *
WS
Line 764:
WS
Line 791:
WS
Line 795: *
WS
Line 803:
WS
Line 811:
WS
Line 827:
WS
Line 984: *
WS
Line 1007: *
WS
Line 1056: *
WS
Line 1083: *
WS
Line 1100: // We have to be careful with substr() because with gcc 2.96, it likes to
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:
Line 139: *
WS
Line 658: *
WS
Line 727: *
WS
Line 794: *
WS
https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
File asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql:
Line 18: */
This file is not needed
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Patch Set 8: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-topic/675/ : ABORTED
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/625
to look at the new patch set (#4).
Change subject: Enabled Feed Tests and Added External Library tests
......................................................................
Enabled Feed Tests and Added External Library tests
Feed tests had been switched off for a while due to having too many
sporadic failures. Now, we are switching them back on.
In addition, a new set of tests have been added to test that external
library works as expected.
Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
---
A asterix-app/data/external-parser/August16-20-long.txt
A asterix-app/data/external-parser/jobads.new
A asterix-app/data/external-parser/jobads.old
A asterix-app/data/external-parser/jobads.txt
A asterix-app/data/external-parser/testdata.txt
A asterix-app/library/externallibtest/testlib/asterix-external-data-0.8.8-SNAPSHOT-tests.jar
A asterix-app/library/externallibtest/testlib/library_descriptor.xml
M asterix-app/pom.xml
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
R asterix-app/src/main/java/org/apache/asterix/app/external/CentralFeedManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedLoadManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedMessageReceiver.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedTrackingManager.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkRequestResponseHandler.java
R asterix-app/src/main/java/org/apache/asterix/app/external/FeedsActivator.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/FeedBootstrap.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
A asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java
M asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser/classad-parser.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.4.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser2/classad-parser2.5.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.3.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/getCapital/getCapital.4.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.2.lib.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.3.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.4.update.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.5.query.aql
A asterix-app/src/test/resources/runtimets/queries/external-library/typed_adapter/typed_adapter.6.lib.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.4.ddl.aql
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser/classad-parser.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/classad-parser2/classad-parser2.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/getCapital/getCapital.1.adm
A asterix-app/src/test/resources/runtimets/results/external-library/typed_adapter/typed_adapter.1.adm
M asterix-app/src/test/resources/runtimets/results/feeds/feeds_03/feeds_03.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
A asterix-common/src/test/java/org/apache/asterix/test/aql/ITestLibrarian.java
M asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/AbstractFeedDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedStreamDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/IndexingDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java
M asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/couchbase/CouchbaseReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/HDFSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java
A asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReaderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AInputStreamReader.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/BasicInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFileSystemInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/TwitterFirehoseStreamProviderFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/HDFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/LocalFSInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/SocketInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/provider/TwitterFirehoseInputStreamProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
M asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableNumberFactor.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CaseInsensitiveString.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/CharArrayLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAd.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdFunc.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdTime.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ClassAdUnParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Common.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/EvalState.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprList.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTree.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/ExprTreeHolder.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FileLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/FunctionCall.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Lexer.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/LexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Literal.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/PrettyPrint.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/StringLexerSource.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/TokenValue.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Util.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/Value.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/AttributeReferencePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/BitSetPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CaseInsensitiveStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/CharArrayStringPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ClassAdPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprHolderPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ExprListPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/LiteralPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/OperationPool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/Pool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/TokenValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/object/pool/ValuePool.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdFunctionalTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdParserTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdToADMTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
A asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParserFactory.java
M asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
R asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ADMDataParserTest.java
A asterix-external-data/src/test/resources/August16-20-long.txt
A asterix-external-data/src/test/resources/functional_tests.txt
A asterix-external-data/src/test/resources/jobads.new
A asterix-external-data/src/test/resources/jobads.old
A asterix-external-data/src/test/resources/jobads.txt
A asterix-external-data/src/test/resources/testdata.txt
A asterix-external-data/src/test/resources/tests.txt
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.1.ddl.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql
A asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.3.query.aql
M asterix-installer/src/test/resources/integrationts/library/testsuite.xml
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
173 files changed, 1,443,009 insertions(+), 300 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/625/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>