You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Damjan Jovanovic <da...@apache.org> on 2015/08/24 22:04:28 UTC
Build and unit test errors with cppunit
Hi
Since commit 1536730 on 2013-10-29 by alg (Armin Le Grand), AOO hasn't
been able to compile with cppunit present and enabled
(--with-system-cppunit), as at least the basegfx and basebmp modules
both have compile errors and unit test failures.
I fixed the basegfx compile errors (brackets in wrong places and
extraneous commas in function arguments) in commits 1697461 and
1697470, but then 6 basegfx units tests still fail, and if I comment
them out, the build fails later with compile errors in basebmp, which
are more complicated as new 3rd and 4th arguments to the
basegfx::tools::importFromSvgD() function are necessary and I am not
sure what they should be.
Please help.
Also why hasn't anybody caught this earlier? Do we not usually compile
AOO with cppunit enabled?
Thank you
Damjan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Build and unit test errors with cppunit
Posted by Kay Schenk <ka...@gmail.com>.
On Mon, Aug 24, 2015 at 8:25 PM, Damjan Jovanovic <da...@gmail.com>
wrote:
> On Mon, Aug 24, 2015 at 11:36 PM, Kay Schenk <ka...@gmail.com> wrote:
> >
> >
> > On 08/24/2015 01:04 PM, Damjan Jovanovic wrote:
> >> Hi
> >>
> >> Since commit 1536730 on 2013-10-29 by alg (Armin Le Grand), AOO hasn't
> >> been able to compile with cppunit present and enabled
> >> (--with-system-cppunit), as at least the basegfx and basebmp modules
> >> both have compile errors and unit test failures.
> >>
> >> I fixed the basegfx compile errors (brackets in wrong places and
> >> extraneous commas in function arguments) in commits 1697461 and
> >> 1697470, but then 6 basegfx units tests still fail, and if I comment
> >> them out, the build fails later with compile errors in basebmp, which
> >> are more complicated as new 3rd and 4th arguments to the
> >> basegfx::tools::importFromSvgD() function are necessary and I am not
> >> sure what they should be.
> >>
> >> Please help.
> >>
> >> Also why hasn't anybody caught this earlier? Do we not usually compile
> >> AOO with cppunit enabled?
> >
> > I think the answer to this is "no". See a post from a few years ago--
> >
> > http://markmail.org/message/kmkv7cr5todacdq6
> >
> > It seems we need some code cleanup to remove the remaining cppunit
> > references.
> >
> >>
> >> Thank you
> >> Damjan
> >
> > If you don't specify anything about cppunit in your config options, you
> > will get a warning that cpppunit will not be used, and thus, no errors.
> >
> > See, for example, config output from linux-32 buildbot --
> >
> https://ci.apache.org/builders/openoffice-linux32-nightly/builds/63/steps/configure/logs/stdio
>
> Thank you, but the reason I used --with-system-cppunit in the first
> place is because I am trying to develop a unit test for a patch I am
> working on. If I can't make a new unit test under /main/<module>/test,
> what can I put it into then? The UNO tests under /main/<module>/qa
> and /main/qadevOOo? The UI tests under /test? Do we have any others?
>
Hi, Damjan--
Pedro was on the right track! Google Test has been integrated into the AOO
framework and that is to be used instead of CPPUNIT. My apologies for not
keeping up with this.
Details:
http://www.mail-archive.com/dev%40openoffice.apache.org/msg18808.html
I don't know how much usage this has gotten since June, 2014 so please keep
us informed about your experience.
--
-------------------------------------------------------------------------------------------------
MzK
“The journey of a thousand miles begins with a single step.”
--Lao Tzu
Re: Build and unit test errors with cppunit
Posted by Damjan Jovanovic <da...@gmail.com>.
On Mon, Aug 24, 2015 at 11:36 PM, Kay Schenk <ka...@gmail.com> wrote:
>
>
> On 08/24/2015 01:04 PM, Damjan Jovanovic wrote:
>> Hi
>>
>> Since commit 1536730 on 2013-10-29 by alg (Armin Le Grand), AOO hasn't
>> been able to compile with cppunit present and enabled
>> (--with-system-cppunit), as at least the basegfx and basebmp modules
>> both have compile errors and unit test failures.
>>
>> I fixed the basegfx compile errors (brackets in wrong places and
>> extraneous commas in function arguments) in commits 1697461 and
>> 1697470, but then 6 basegfx units tests still fail, and if I comment
>> them out, the build fails later with compile errors in basebmp, which
>> are more complicated as new 3rd and 4th arguments to the
>> basegfx::tools::importFromSvgD() function are necessary and I am not
>> sure what they should be.
>>
>> Please help.
>>
>> Also why hasn't anybody caught this earlier? Do we not usually compile
>> AOO with cppunit enabled?
>
> I think the answer to this is "no". See a post from a few years ago--
>
> http://markmail.org/message/kmkv7cr5todacdq6
>
> It seems we need some code cleanup to remove the remaining cppunit
> references.
>
>>
>> Thank you
>> Damjan
>
> If you don't specify anything about cppunit in your config options, you
> will get a warning that cpppunit will not be used, and thus, no errors.
>
> See, for example, config output from linux-32 buildbot --
> https://ci.apache.org/builders/openoffice-linux32-nightly/builds/63/steps/configure/logs/stdio
Thank you, but the reason I used --with-system-cppunit in the first
place is because I am trying to develop a unit test for a patch I am
working on. If I can't make a new unit test under /main/<module>/test,
what can I put it into then? The UNO tests under /main/<module>/qa
and /main/qadevOOo? The UI tests under /test? Do we have any others?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Build and unit test errors with cppunit
Posted by Kay Schenk <ka...@gmail.com>.
On 08/24/2015 01:04 PM, Damjan Jovanovic wrote:
> Hi
>
> Since commit 1536730 on 2013-10-29 by alg (Armin Le Grand), AOO hasn't
> been able to compile with cppunit present and enabled
> (--with-system-cppunit), as at least the basegfx and basebmp modules
> both have compile errors and unit test failures.
>
> I fixed the basegfx compile errors (brackets in wrong places and
> extraneous commas in function arguments) in commits 1697461 and
> 1697470, but then 6 basegfx units tests still fail, and if I comment
> them out, the build fails later with compile errors in basebmp, which
> are more complicated as new 3rd and 4th arguments to the
> basegfx::tools::importFromSvgD() function are necessary and I am not
> sure what they should be.
>
> Please help.
>
> Also why hasn't anybody caught this earlier? Do we not usually compile
> AOO with cppunit enabled?
I think the answer to this is "no". See a post from a few years ago--
http://markmail.org/message/kmkv7cr5todacdq6
It seems we need some code cleanup to remove the remaining cppunit
references.
>
> Thank you
> Damjan
If you don't specify anything about cppunit in your config options, you
will get a warning that cpppunit will not be used, and thus, no errors.
See, for example, config output from linux-32 buildbot --
https://ci.apache.org/builders/openoffice-linux32-nightly/builds/63/steps/configure/logs/stdio
--
--------------------------------------------
MzK
“The journey of a thousand miles begins
with a single step.”
--Lao Tzu
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org