You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/22 19:07:25 UTC
[GitHub] [iceberg] rdblue opened a new pull request #2139: Do not redistribute MERGE INTO rows unless the table is sorted
rdblue opened a new pull request #2139:
URL: https://github.com/apache/iceberg/pull/2139
This changes the distribution mode used by default to write the output of MERGE INTO to `none` if the table is unsorted, rather than `range`. Range distribution is expensive because it uses an extra round-robin exchange and has an extra stage to estimate skew. If the sort order of the table is not set, then it is not worth adding the extra stages for the inferred sort order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dilipbiswal commented on pull request #2139: Do not redistribute MERGE INTO rows unless the table is sorted
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on pull request #2139:
URL: https://github.com/apache/iceberg/pull/2139#issuecomment-765652964
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2139: Do not redistribute MERGE INTO rows unless the table is sorted
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2139:
URL: https://github.com/apache/iceberg/pull/2139#issuecomment-765707965
It it the flaky test in JDK 8, but JDK 11 passed. I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2139: Do not redistribute MERGE INTO rows unless the table is sorted
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2139:
URL: https://github.com/apache/iceberg/pull/2139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2139: Do not redistribute MERGE INTO rows unless the table is sorted
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2139:
URL: https://github.com/apache/iceberg/pull/2139#discussion_r562855134
##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -266,5 +271,15 @@ case class RewriteMergeInto(spark: SparkSession) extends Rule[LogicalPlan] with
}
}
}
+
+ private implicit class TableHelper(table: Table) {
Review comment:
nit: I wonder whether it would make sense to return Iceberg `Table` here, instead of `SparkTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2139: Do not redistribute MERGE INTO rows unless the table is sorted
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2139:
URL: https://github.com/apache/iceberg/pull/2139#discussion_r562855327
##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -266,5 +271,15 @@ case class RewriteMergeInto(spark: SparkSession) extends Rule[LogicalPlan] with
}
}
}
+
+ private implicit class TableHelper(table: Table) {
Review comment:
This broke the other table helper, so I removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org